Skip to content

#1802: fixed gui-launcher pom.xml not being included in native images on nightly/release builds.#1894

Open
laim2003 wants to merge 4 commits intodevonfw:mainfrom
laim2003:#1892-fix-gui-pom-not-included-in-release
Open

#1802: fixed gui-launcher pom.xml not being included in native images on nightly/release builds.#1894
laim2003 wants to merge 4 commits intodevonfw:mainfrom
laim2003:#1892-fix-gui-pom-not-included-in-release

Conversation

@laim2003
Copy link
Copy Markdown
Contributor

@laim2003 laim2003 commented May 5, 2026

This PR fixes #1892

Implemented changes:

  • Updated nightly-build and release workflows to properly generate the .flattened_pom.xml in gui-launcher before completing the assembly build. After generating, now the assembly build can properly copy the .flattened_pom.xml from gui-launcher to cli target directory, allowing the pom.xml to be included in the native images.
  • The gui commandlet had a little issue leading to the commandlet to download the latest java version (e.g. 26) instead of only using the 25 version.

Checklist for this PR

Make sure everything is checked before merging this PR. For further info please also see
our DoD.

  • When running mvn clean test locally all tests pass and build is successful
  • PR title is of the form #«issue-id»: «brief summary» (e.g. #921: fixed setup.bat). If no issue ID exists, title only.
  • PR top-level comment summarizes what has been done and contains link to addressed issue(s)
  • PR and issue(s) have suitable labels
  • Issue is set to In Progress and assigned to you or there is no issue (might happen for very small PRs)
  • You followed all coding conventions
  • You have added the issue implemented by your PR in CHANGELOG.adoc unless issue is labeled
    with internal

…ghtly & release builds to correctly copy the flattened_pom from gui-launcher into the native images before processing those.
@github-project-automation github-project-automation Bot moved this to 🆕 New in IDEasy board May 5, 2026
@laim2003 laim2003 moved this from 🆕 New to 🏗 In progress in IDEasy board May 5, 2026
@laim2003 laim2003 moved this from 🏗 In progress to 👀 In review in IDEasy board May 5, 2026
@laim2003 laim2003 self-assigned this May 5, 2026
@laim2003 laim2003 added release related to release commandlet and releases of IDEasy GUI Graphical User Interface of IDEasy (aka dashboard) build with JavaFx internal Nothing to be added to CHANGELOG, only internal story labels May 5, 2026
@coveralls
Copy link
Copy Markdown
Collaborator

Coverage Report for CI Build 25388299526

Coverage remained the same at 70.728%

Details

  • Coverage remained the same as the base build.
  • Patch coverage: No coverable lines changed in this PR.
  • No coverage regressions found.

Uncovered Changes

No uncovered changes found.

Coverage Regressions

No coverage regressions found.


Coverage Stats

Coverage Status
Relevant Lines: 15403
Covered Lines: 11355
Line Coverage: 73.72%
Relevant Branches: 6878
Covered Branches: 4404
Branch Coverage: 64.03%
Branches in Coverage %: Yes
Coverage Strength: 3.12 hits per line

💛 - Coveralls

Comment thread .github/workflows/nightly-build.yml Outdated
laim2003 added 3 commits May 5, 2026 20:58
…ion commandlet; Removed specification of java version in Gui commandlet, so default java version of current IDEasy version is used
@laim2003 laim2003 marked this pull request as ready for review May 5, 2026 19:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

GUI Graphical User Interface of IDEasy (aka dashboard) build with JavaFx internal Nothing to be added to CHANGELOG, only internal story release related to release commandlet and releases of IDEasy

Projects

Status: 👀 In review

Development

Successfully merging this pull request may close these issues.

pom.xml required for launching gui not included in release/native builds

2 participants