Skip to content

#836: fix exit autocompletion#1950

Merged
hohwille merged 2 commits into
devonfw:mainfrom
Caylipp:feature/836-fix-exit-autocomplete
May 21, 2026
Merged

#836: fix exit autocompletion#1950
hohwille merged 2 commits into
devonfw:mainfrom
Caylipp:feature/836-fix-exit-autocomplete

Conversation

@Caylipp
Copy link
Copy Markdown
Contributor

@Caylipp Caylipp commented May 18, 2026

This PR fixes #836

Implemented changes:

  • fixed autocomplete behavior for exit command
  • ensured exit is only suggested in valid context

How to Test:

Run in Git Bash:

mvn -pl cli exec:java -Dexec.mainClass=com.devonfw.tools.ide.cli.Ideasy -Dexec.args="shell"

Then verify:

  • e<TAB> -> suggests exit
  • <TAB> with empty input -> no exit
  • z<TAB> -> no exit
  • after other commands (intellij e<TAB>) -> no exit

Checklist for this PR

Make sure everything is checked before merging this PR. For further info please also see
our DoD.

  • When running mvn clean test locally all tests pass and build is successful
  • PR title is of the form #«issue-id»: «brief summary» (e.g. #921: fixed setup.bat). If no issue ID exists, title only.
  • PR top-level comment summarizes what has been done and contains link to addressed issue(s)
  • PR and issue(s) have suitable labels
  • Issue is set to In Progress and assigned to you or there is no issue (might happen for very small PRs)
  • You followed all coding conventions
  • You have added the issue implemented by your PR in CHANGELOG.adoc unless issue is labeled
    with internal

@CLAassistant
Copy link
Copy Markdown

CLAassistant commented May 18, 2026

CLA assistant check
All committers have signed the CLA.

@coveralls
Copy link
Copy Markdown
Collaborator

coveralls commented May 18, 2026

Coverage Report for CI Build 26149130916

Warning

No base build found for commit 908c0a7 on main.
Coverage changes can't be calculated without a base build.
If a base build is processing, this comment will update automatically when it completes.

Coverage: 70.947%

Details

  • Patch coverage: No coverable lines changed in this PR.

Uncovered Changes

No uncovered changes found.

Coverage Regressions

Requires a base build to compare against. How to fix this →


Coverage Stats

Coverage Status
Relevant Lines: 15515
Covered Lines: 11479
Line Coverage: 73.99%
Relevant Branches: 6934
Covered Branches: 4448
Branch Coverage: 64.15%
Branches in Coverage %: Yes
Coverage Strength: 3.13 hits per line

💛 - Coveralls

@hohwille hohwille moved this from 🆕 New to Team Review in IDEasy board May 18, 2026
@Caylipp Caylipp added the shell build-in shell with advanced completion label May 18, 2026
Comment thread cli/src/main/java/com/devonfw/tools/ide/commandlet/ShellCommandlet.java Outdated
Caylipp added 2 commits May 20, 2026 09:47
- restored exit command handling since it is actual shell functionality
- removed anonymous completer wrapper
- moved exit completion logic into IdeCompleter
- added EXIT_COMMAND constant
@Caylipp Caylipp force-pushed the feature/836-fix-exit-autocomplete branch from d7b4d41 to d09cc84 Compare May 20, 2026 07:52
@hohwille hohwille merged commit a61a0fa into devonfw:main May 21, 2026
4 checks passed
@github-project-automation github-project-automation Bot moved this from Team Review to ✅ Done in IDEasy board May 21, 2026
@hohwille hohwille added this to the release:2026.05.001 milestone May 21, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

shell build-in shell with advanced completion

Projects

Status: ✅ Done

Development

Successfully merging this pull request may close these issues.

Exit is completed in wrong places

5 participants