Skip to content

#863: support for .dmg downloads in AndroidStudioUrlUpdater#1959

Merged
hohwille merged 4 commits into
devonfw:mainfrom
shodiBoy1:feature/863-android-studio-mac-urls
May 22, 2026
Merged

#863: support for .dmg downloads in AndroidStudioUrlUpdater#1959
hohwille merged 4 commits into
devonfw:mainfrom
shodiBoy1:feature/863-android-studio-mac-urls

Conversation

@shodiBoy1
Copy link
Copy Markdown
Contributor

@shodiBoy1 shodiBoy1 commented May 20, 2026

This PR fixes #863

Implemented changes:

  • AndroidStudioUrlUpdater: also accept mac.dmg / mac_arm.dmg in addition to mac.zip / mac_arm.zip. Android Studio switched the macOS distribution from ZIP to DMG starting with the 2024.x releases, so the previous suffix check produced no Mac

Testing instructions

After merge, check the next day that the missing downloads for mac (today no mac urls is present) can be found e.g. here:
https://github.com/devonfw/ide-urls/tree/master/android-studio/android-studio/2024.3.1.9


Checklist for this PR

  • When running mvn clean test locally all tests pass and build is successful
  • PR title is of the form #«issue-id»: «brief summary» (e.g. #921: fixed setup.bat). If no issue ID exists, title only.
  • PR top-level comment summarizes what has been done and contains link to addressed issue(s)
  • PR and issue(s) have suitable labels
  • Issue is set to In Progress and assigned to you or there is no issue (might happen for very small PRs)
  • You followed all coding conventions
  • You have added the issue implemented by your PR in CHANGELOG.adoc unless issue is labeled
    with internal
  • You have formulated clear instructions on how to test your contribution under "Testing instructions"

@github-project-automation github-project-automation Bot moved this to 🆕 New in IDEasy board May 20, 2026
@shodiBoy1 shodiBoy1 self-assigned this May 20, 2026
@shodiBoy1 shodiBoy1 added android-studio Android Studio IDE from Jet-Brains macOS specific for Apple MacOS labels May 20, 2026
@shodiBoy1 shodiBoy1 moved this from 🆕 New to 🏗 In progress in IDEasy board May 20, 2026
@coveralls
Copy link
Copy Markdown
Collaborator

coveralls commented May 20, 2026

Coverage Report for CI Build 26283142239

Coverage increased (+0.05%) to 71.115%

Details

  • Coverage increased (+0.05%) from the base build.
  • Patch coverage: No coverable lines changed in this PR.
  • 1 coverage regression across 1 file.

Uncovered Changes

No uncovered changes found.

Coverage Regressions

1 previously-covered line in 1 file lost coverage.

File Lines Losing Coverage Coverage
com/devonfw/tools/ide/url/tool/androidstudio/AndroidStudioUrlUpdater.java 1 89.47%

Coverage Stats

Coverage Status
Relevant Lines: 15566
Covered Lines: 11546
Line Coverage: 74.17%
Relevant Branches: 6954
Covered Branches: 4469
Branch Coverage: 64.27%
Branches in Coverage %: Yes
Coverage Strength: 3.14 hits per line

💛 - Coveralls

Copy link
Copy Markdown
Member

@hohwille hohwille left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@shodiBoy1 thanks for your PR. Looks perfectly plausible to me and I consider your PR as ready for merge. 👍
If you agree and take it out of draft, we can use fast lane and I will directly merge it.

@github-project-automation github-project-automation Bot moved this from 🏗 In progress to 👀 In review in IDEasy board May 21, 2026
@hohwille hohwille changed the title support for .dmg downloads in AndroidStudioUrlUpdater #863: support for .dmg downloads in AndroidStudioUrlUpdater May 21, 2026
@shodiBoy1 shodiBoy1 marked this pull request as ready for review May 21, 2026 22:26
@shodiBoy1
Copy link
Copy Markdown
Contributor Author

@hohwille all done , ready for merge!

@hohwille hohwille added this to the release:2026.05.001 milestone May 22, 2026
Copy link
Copy Markdown
Member

@hohwille hohwille left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@shodiBoy1 thanks for the update and also considering that we need to ignore .exe files. 👍
Ready for merge.

@hohwille hohwille merged commit e59aac5 into devonfw:main May 22, 2026
2 checks passed
@github-project-automation github-project-automation Bot moved this from 👀 In review to ✅ Done in IDEasy board May 22, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

android-studio Android Studio IDE from Jet-Brains macOS specific for Apple MacOS

Projects

Status: ✅ Done

Development

Successfully merging this pull request may close these issues.

Mac x64 android-studio 2024 releases missing

3 participants