#863: support for .dmg downloads in AndroidStudioUrlUpdater#1959
Merged
hohwille merged 4 commits intoMay 22, 2026
Conversation
Collaborator
Coverage Report for CI Build 26283142239Coverage increased (+0.05%) to 71.115%Details
Uncovered ChangesNo uncovered changes found. Coverage Regressions1 previously-covered line in 1 file lost coverage.
Coverage Stats💛 - Coveralls |
hohwille
approved these changes
May 21, 2026
Member
hohwille
left a comment
There was a problem hiding this comment.
@shodiBoy1 thanks for your PR. Looks perfectly plausible to me and I consider your PR as ready for merge. 👍
If you agree and take it out of draft, we can use fast lane and I will directly merge it.
hohwille
reviewed
May 21, 2026
Contributor
Author
|
@hohwille all done , ready for merge! |
hohwille
approved these changes
May 22, 2026
Member
hohwille
left a comment
There was a problem hiding this comment.
@shodiBoy1 thanks for the update and also considering that we need to ignore .exe files. 👍
Ready for merge.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes #863
Implemented changes:
Testing instructions
After merge, check the next day that the missing downloads for mac (today no mac urls is present) can be found e.g. here:
https://github.com/devonfw/ide-urls/tree/master/android-studio/android-studio/2024.3.1.9
Checklist for this PR
mvn clean testlocally all tests pass and build is successful#«issue-id»: «brief summary»(e.g.#921: fixed setup.bat). If no issue ID exists, title only.In Progressand assigned to you or there is no issue (might happen for very small PRs)with
internal