Skip to content

avoid external URLs for images in documentation that can break the build when unavailable#1972

Merged
hohwille merged 1 commit into
devonfw:mainfrom
hohwille:feature/fix-doc-build-image-from-url
May 26, 2026
Merged

avoid external URLs for images in documentation that can break the build when unavailable#1972
hohwille merged 1 commit into
devonfw:mainfrom
hohwille:feature/fix-doc-build-image-from-url

Conversation

@hohwille
Copy link
Copy Markdown
Member

@hohwille hohwille commented May 26, 2026

avoid external URLs for images in documentation that can break the build when unavailable

This PR fixes the build pipeline

Error:  asciidoctor: ERROR: IDEasy.adoc: failed to parse formatted text: [Intergate git-bash into Windows-Terminal] | <em>https://mobeigi.com/_next/image/?url=%2Fapi%2Fmedia%2Ffile%2Fgit-installer-windows-terminal-profile.webp&w=1200&q=75</em>

Implemented changes:

  • replace image URL with local image file reference

Testing instructions

Please add conscise, understandable instructions on how a reviewer can test/verify the functionality of your contribution here:

  1. Check that build pipeline and NightlyBuild goes back to green.

Checklist for this PR

Make sure everything is checked before merging this PR. For further info please also see
our DoD.

  • When running mvn clean test locally all tests pass and build is successful
  • PR title is of the form #«issue-id»: «brief summary» (e.g. #921: fixed setup.bat). If no issue ID exists, title only.
  • PR top-level comment summarizes what has been done and contains link to addressed issue(s)
  • PR and issue(s) have suitable labels
  • Issue is set to In Progress and assigned to you or there is no issue (might happen for very small PRs)
  • You followed all coding conventions
  • You have added the issue implemented by your PR in CHANGELOG.adoc unless issue is labeled
    with internal
  • You have formulated clear instructions on how to test your contribution under "Testing instructions"

@hohwille hohwille added this to the release:2026.05.001 milestone May 26, 2026
@hohwille hohwille self-assigned this May 26, 2026
@hohwille hohwille added documentation Improvements or additions to documentation enhancement New feature or request bugfix PR that fixes a bug issue internal Nothing to be added to CHANGELOG, only internal story workflow GitHub actions (CI,CD,update urls/CVEs) labels May 26, 2026
@github-project-automation github-project-automation Bot moved this to 🆕 New in IDEasy board May 26, 2026
@hohwille hohwille moved this from 🆕 New to 👀 In review in IDEasy board May 26, 2026
@coveralls
Copy link
Copy Markdown
Collaborator

Coverage Report for CI Build 26443679403

Warning

No base build found for commit 22c5b14 on main.
Coverage changes can't be calculated without a base build.
If a base build is processing, this comment will update automatically when it completes.

Coverage: 71.132%

Details

  • Patch coverage: No coverable lines changed in this PR.

Uncovered Changes

No uncovered changes found.

Coverage Regressions

Requires a base build to compare against. How to fix this →


Coverage Stats

Coverage Status
Relevant Lines: 15566
Covered Lines: 11547
Line Coverage: 74.18%
Relevant Branches: 6954
Covered Branches: 4472
Branch Coverage: 64.31%
Branches in Coverage %: Yes
Coverage Strength: 3.14 hits per line

💛 - Coveralls

@hohwille hohwille merged commit 3f72f5d into devonfw:main May 26, 2026
4 checks passed
@github-project-automation github-project-automation Bot moved this from 👀 In review to ✅ Done in IDEasy board May 26, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bugfix PR that fixes a bug issue documentation Improvements or additions to documentation enhancement New feature or request internal Nothing to be added to CHANGELOG, only internal story workflow GitHub actions (CI,CD,update urls/CVEs)

Projects

Status: ✅ Done

Development

Successfully merging this pull request may close these issues.

2 participants