Skip to content

fix nighly build#2116

Merged
hohwille merged 3 commits into
devonfw:mainfrom
Caylipp:fix-nightly-build
Jul 6, 2026
Merged

fix nighly build#2116
hohwille merged 3 commits into
devonfw:mainfrom
Caylipp:fix-nightly-build

Conversation

@Caylipp

@Caylipp Caylipp commented Jul 6, 2026

Copy link
Copy Markdown
Contributor

This PR fixes the build that was broken by PR #2094

Implemented changes:

  • fix nighly build

Testing instructions

Please add conscise, understandable instructions on how a reviewer can test/verify the functionality of your contribution here:

  1. Observe the workflow run on GitHub next day or run it manually.

Checklist for this PR

Make sure everything is checked before merging this PR. For further info please also see
our DoD.

  • When running mvn clean test locally all tests pass and build is successful
  • PR title is of the form #«issue-id»: «brief summary» (e.g. #921: fixed setup.bat). If no issue ID exists, title only.
  • PR top-level comment summarizes what has been done and contains link to addressed issue(s)
  • PR and issue(s) have suitable labels
  • Issue is set to In Progress and assigned to you or there is no issue (might happen for very small PRs)
  • You followed all coding conventions
  • You have added the issue implemented by your PR in CHANGELOG.adoc unless issue is labeled
    with internal
  • You have formulated clear instructions on how to test your contribution under "Testing instructions"

- improve copy constructor
- using complete constant
@github-project-automation github-project-automation Bot moved this to 🆕 New in IDEasy board Jul 6, 2026
@Caylipp Caylipp self-assigned this Jul 6, 2026
@coveralls

coveralls commented Jul 6, 2026

Copy link
Copy Markdown
Collaborator

Coverage Report for CI Build 28816359737

Warning

Build has drifted: This PR's base is out of sync with its target branch, so coverage data may include unrelated changes.
Quick fix: rebase this PR. Learn more →

Coverage increased (+0.008%) to 71.815%

Details

  • Coverage increased (+0.008%) from the base build.
  • Patch coverage: No coverable lines changed in this PR.
  • No coverage regressions found.

Uncovered Changes

No uncovered changes found.

Coverage Regressions

No coverage regressions found.


Coverage Stats

Coverage Status
Relevant Lines: 16556
Covered Lines: 12393
Line Coverage: 74.86%
Relevant Branches: 7432
Covered Branches: 4834
Branch Coverage: 65.04%
Branches in Coverage %: Yes
Coverage Strength: 3.17 hits per line

💛 - Coveralls

@vivu001 vivu001 self-assigned this Jul 6, 2026
@vivu001 vivu001 moved this from 🆕 New to Team Review in IDEasy board Jul 6, 2026
@vivu001

vivu001 commented Jul 6, 2026

Copy link
Copy Markdown
Contributor

@Caylipp It looks good. The missing WixUI_FirstStepsDlg.wxs was added to the WIX build command.

@vivu001 vivu001 moved this from Team Review to 👀 In review in IDEasy board Jul 6, 2026

@hohwille hohwille left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Caylipp and @vivu001 thanks for this quick fix. 👍
Please also update the release workflow so it will also be fixed.

Comment thread .github/workflows/nightly-build.yml
Comment thread windows-installer/README.adoc Outdated
@hohwille hohwille marked this pull request as ready for review July 6, 2026 15:02
@hohwille hohwille added this to the release:2026.07.001 milestone Jul 6, 2026
@hohwille hohwille added bugfix PR that fixes a bug issue windows specific for Microsoft Windows OS install installation process of IDE + tools and install commandlet internal Nothing to be added to CHANGELOG, only internal story labels Jul 6, 2026
@hohwille hohwille merged commit 4ad48a6 into devonfw:main Jul 6, 2026
3 checks passed
@github-project-automation github-project-automation Bot moved this from 👀 In review to ✅ Done in IDEasy board Jul 6, 2026
@hohwille

hohwille commented Jul 7, 2026

Copy link
Copy Markdown
Member

Retest: Nightly build is working again.

@hohwille hohwille added the QA approved Label a PR that has been re-testet via nightly SNAPSHOT after merge and commented. label Jul 7, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bugfix PR that fixes a bug issue install installation process of IDE + tools and install commandlet internal Nothing to be added to CHANGELOG, only internal story QA approved Label a PR that has been re-testet via nightly SNAPSHOT after merge and commented. windows specific for Microsoft Windows OS

Projects

Status: ✅ Done

Development

Successfully merging this pull request may close these issues.

4 participants