#1808: do not report a workspace when icd navigates to the project root#2125
Open
maybeec wants to merge 2 commits into
Open
#1808: do not report a workspace when icd navigates to the project root#2125maybeec wants to merge 2 commits into
maybeec wants to merge 2 commits into
Conversation
Collaborator
Coverage Report for CI Build 28850392142Coverage increased (+0.02%) to 72.087%Details
Uncovered ChangesNo uncovered changes found. Coverage RegressionsNo coverage regressions found. Coverage Stats💛 - Coveralls |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes #1808
Implemented changes:
icdcommand (and the sharedideshell integration it reuses) no longer claims you arein workspace mainwhen you actually navigate to the project root.workspaces/<name>folder:icd -p «project»→IDE environment variables have been set for «home»(no workspace mentioned)icd -p «project» -w [«name»]→... in workspace «name»(unchanged)icdinside a project → jumps to the project root →... for «home»(no workspace)icdwith no project → only navigates to the projects root (IDE_ROOT), no environment setup and no message (unchanged)ide.batwrapper for cross-platform consistency.cli.adoc,features.adoc) and added aCHANGELOG.adocentry.This is a message-only change; the navigation semantics of
-p/-w(as designed and discussed in the issue) are unchanged.Testing instructions
bash cli/src/test/functions-test.sh— all tests pass (includes newicdmessage tests covering project-root vs. workspace).icd -p «project». The output must readIDE environment variables have been set for «...»/«project»withoutin workspace main.icd -p «project» -wand confirm it still reports... in workspace main(you are now inside the workspace).icdand confirm it jumps to the project root and reports... for «home»without a workspace.Checklist for this PR
Make sure everything is checked before merging this PR. For further info please also see
our DoD.
mvn clean testlocally all tests pass and build is successful#«issue-id»: «brief summary»(e.g.#921: fixed setup.bat). If no issue ID exists, title only.In Progressand assigned to you or there is no issue (might happen for very small PRs)internal