Skip to content

#533: Add autocompletion of exit in ide shell#707

Merged
hohwille merged 8 commits intodevonfw:mainfrom
WorkingAmeise:enhancement/533-add-autocompletion-of-exit-to-shell
Oct 26, 2024
Merged

#533: Add autocompletion of exit in ide shell#707
hohwille merged 8 commits intodevonfw:mainfrom
WorkingAmeise:enhancement/533-add-autocompletion-of-exit-to-shell

Conversation

@WorkingAmeise
Copy link
Copy Markdown
Contributor

Closes #533

Implements:

  • When in ide shell 'exit' is now suggested when e is typed and tab is pressed
  • Pressing enter successfully aborts the shell

@WorkingAmeise WorkingAmeise self-assigned this Oct 22, 2024
@WorkingAmeise WorkingAmeise added the enhancement New feature or request label Oct 22, 2024
@coveralls
Copy link
Copy Markdown
Collaborator

coveralls commented Oct 22, 2024

Pull Request Test Coverage Report for Build 11514405476

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 39 unchanged lines in 2 files lost coverage.
  • Overall coverage decreased (-0.05%) to 66.759%

Files with Coverage Reduction New Missed Lines %
com/devonfw/tools/ide/url/model/file/json/ToolDependencies.java 1 76.92%
com/devonfw/tools/ide/commandlet/ShellCommandlet.java 38 3.7%
Totals Coverage Status
Change from base Build 11497084978: -0.05%
Covered Lines: 6266
Relevant Lines: 9038

💛 - Coveralls

@jan-vcapgemini jan-vcapgemini self-assigned this Oct 23, 2024
Copy link
Copy Markdown
Contributor

@jan-vcapgemini jan-vcapgemini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. I've added some questions, but overall this can get into review now.

Copy link
Copy Markdown
Member

@hohwille hohwille left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@WorkingAmeise thanks for your PR. Looks like you found the correct solution. All looking fine and nothing to rework. Also you added the issue to the changelog so you really nailed it - great job👍

@hohwille hohwille changed the title #533 Add autocompletion of exit in ide shell #533: Add autocompletion of exit in ide shell Oct 25, 2024
@hohwille hohwille added completion auto-completion in bash or build in CLI shell build-in shell with advanced completion labels Oct 25, 2024
@hohwille hohwille added this to the release:2024.10.001 milestone Oct 25, 2024
@hohwille hohwille merged commit b15bfdf into devonfw:main Oct 26, 2024
blizzarac added a commit to blizzarac/IDEasy that referenced this pull request Oct 27, 2024
* 'main' of github.com:blizzarac/IDEasy:
  devonfw#533: Add autocompletion of exit in ide shell (devonfw#707)
  Update advanced-tooling-windows.adoc
  simplify FlagProperty usage and allow ToolCommandlets to have long options (devonfw#644)
  Update CHANGELOG.adoc: prepare 2024.10.001
  devonfw#685: update dependencies, added missing deps to LICENSE.adoc, doc rework, jakarta migration (devonfw#686)
  devonfw#689: Added urls to tests (devonfw#695)
MarvMa pushed a commit to MarvMa/IDEasy that referenced this pull request Apr 17, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

completion auto-completion in bash or build in CLI enhancement New feature or request shell build-in shell with advanced completion

Projects

Status: ✅ Done

Development

Successfully merging this pull request may close these issues.

Add autocompletion of 'exit' to shell

4 participants