Skip to content

Update ProcessContext.java: fixed crazy bug with pointless vararg for List#712

Merged
hohwille merged 4 commits intomainfrom
feature/fix-process-context-vararg-list
Oct 28, 2024
Merged

Update ProcessContext.java: fixed crazy bug with pointless vararg for List#712
hohwille merged 4 commits intomainfrom
feature/fix-process-context-vararg-list

Conversation

@hohwille
Copy link
Member

Quickfix for odd API bug I found during code-review.

@hohwille hohwille added enhancement New feature or request process executing external programs (ProcessContext) labels Oct 25, 2024
@hohwille hohwille added this to the release:2024.10.001 milestone Oct 25, 2024
Copy link
Contributor

@jan-vcapgemini jan-vcapgemini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@coveralls
Copy link
Collaborator

coveralls commented Oct 28, 2024

Pull Request Test Coverage Report for Build 11559289705

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage increased (+0.01%) to 66.746%

Files with Coverage Reduction New Missed Lines %
com/devonfw/tools/ide/process/ProcessContext.java 1 40.0%
Totals Coverage Status
Change from base Build 11559284890: 0.01%
Covered Lines: 6270
Relevant Lines: 9048

💛 - Coveralls

@hohwille hohwille merged commit 44278a9 into main Oct 28, 2024
@hohwille hohwille self-assigned this Oct 28, 2024
@hohwille hohwille deleted the feature/fix-process-context-vararg-list branch October 31, 2024 13:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request process executing external programs (ProcessContext)

Projects

Status: ✅ Done

Development

Successfully merging this pull request may close these issues.

3 participants