#673: fixed tomcat and improved logging#725
Merged
hohwille merged 2 commits intodevonfw:mainfrom Oct 29, 2024
Merged
Conversation
hohwille
added
enhancement
Collaborator
Pull Request Test Coverage Report for Build 11578617032Details
💛 - Coveralls |
hohwille
changed the title
| if (Files.exists(file)) { | ||
| try (BufferedReader reader = Files.newBufferedReader(file)) { | ||
| TypeReference<HashMap<VersionRange, List<ToolDependency>>> typeRef = new TypeReference<>() { | ||
| TypeReference<TreeMap<VersionRange, List<ToolDependency>>> typeRef = new TypeReference<>() { |
Contributor
There was a problem hiding this comment.
Why was this converted to a TreeMap?
I've found out that a LinkedHashMap would be more effective, if we don't want to change the ordering.
See: https://www.baeldung.com/java-treemap
| private void installToolDependencies(VersionIdentifier version, String edition, EnvironmentContext environmentContext, ToolRepository toolRepository) { | ||
| Collection<ToolDependency> dependencies = toolRepository.findDependencies(this.tool, edition, version); | ||
| String toolWithEdition = getToolWithEdition(this.tool, edition); | ||
| int size = dependencies.size(); |
Contributor
There was a problem hiding this comment.
Does not look like we need this variable. Only used once.
Contributor
jan-vcapgemini
left a comment
jan-vcapgemini
left a comment
There was a problem hiding this comment.
I've added some questions, please check.
nmCapG
pushed a commit
to nmCapG/IDEasy
that referenced
this pull request
Oct 30, 2024
hohwille
added
dependencies
MarvMa
pushed a commit
to MarvMa/IDEasy
that referenced
this pull request
Apr 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #673
environmentContextwas not passed to recursiveinstallmethod (in such situations a NPE would have been preferred that is prevented by the EMPTY instance of EnvironmentContext)