#751: Moved postInstall() and changed tool installation message#763
Conversation
Moved the method postInstall from GlobalToolCommandlet to LocalToolCommandlet and changed the installation message so that the user is not getting confused
jan-vcapgemini
left a comment
There was a problem hiding this comment.
LGTM. Ready for review.
hohwille
left a comment
There was a problem hiding this comment.
@leonrohne27 thanks for your PR. You solved the second task of #751 nicely. 👍
For the first task there is a slight misunderstanding - sorry, if I was not precise enough:
Move postInstall() to LocalToolCommandlet and remove it from [Global]ToolCommandlet:
I expect that the postInstall method(s) (with its body/implementation) gets moved to LocalToolCommandlet. If GlobalToolCommandlet does not support postInstall, then it does not make sense anymore if it has a method postInstall.
It is fully correct that you removed the invocation of postInstall() from GlobalToolCommandlet but you also need to move postInstall() and postInstall(boolean) from ToolCommandlet to LocalToolCommandlet.
Then sub-classes of GlobalToolCommandlet cannot override postInstall anymore and since we always use @Override annotations in such case, we would even get compile errors if we missed something.
Please have a look and update your PR. Thanks.
cli/src/main/java/com/devonfw/tools/ide/tool/LocalToolCommandlet.java
Outdated
Show resolved
Hide resolved
…et.java Co-authored-by: Jörg Hohwiller <hohwille@users.noreply.github.com>
Pull Request Test Coverage Report for Build 11888068434Details
💛 - Coveralls |
moved postInstall() from ToolCommandlet to LocalToolCommandlet
…github.com/leonrohne27/IDEasy into fix/751-small-cleanup-globaltoolcommandlet
hohwille
left a comment
There was a problem hiding this comment.
@leonrohne27 thanks for rework, ready for merge now 👍
Fixes: #751
Implements: