Skip to content

#327: fix error handling for completable future #328

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
hohwille merged 3 commits into from
Dec 17, 2020
Merged

#327: fix error handling for completable future #328

hohwille merged 3 commits into from
Dec 17, 2020

Conversation

@hohwille
Copy link
Member

@hohwille hohwille commented Dec 17, 2020

@hohwille hohwille added bug Something isn't working enhancement New feature or request service service-layer (REST, SOAP, etc.) labels Dec 17, 2020
@hohwille hohwille added this to the release:2020.12.001 milestone Dec 17, 2020
@hohwille hohwille linked an issue Dec 17, 2020 that may be closed by this pull request
CompletableFuture returns null if service failed instead of raising exception #327
Closed
@hohwille
Copy link
Member Author

hohwille commented Dec 17, 2020 •
edited
Loading

We could still invoke the errorHandler before throwing the exception in the CompletableFuture.
Any thoughts on this design from others?
Currently this is not the case and I updated the JavaDoc to explain the behaviour. We could change this now if we think this would be better. If we do change this, the errorHandler implementation needs to be thread-safe.

As CompletableFuture by design throws a checked ExecutionException the user is forced to handle errors anyway. Therefore, I think my change here is suitable and makes sense.

@hohwille hohwille merged commit 43b56bc into devonfw:develop Dec 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@maybeec maybeec maybeec approved these changes

@ssarmokadam ssarmokadam ssarmokadam approved these changes

Assignees

No one assigned

Labels

bug Something isn't working enhancement New feature or request service service-layer (REST, SOAP, etc.)

Projects

None yet

Milestone

release:2020.12.001

Development

Successfully merging this pull request may close these issues.

CompletableFuture returns null if service failed instead of raising exception

3 participants

@hohwille @maybeec @ssarmokadam