-
Notifications
You must be signed in to change notification settings - Fork 12
Feature/oauth2 proxy #31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
baumeister25
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
IMHO the solution should be on a more abstract level.
In some parts it's very concrete (bitnami helm charts, localtest.me)
I think we should focus on 2 different things.
First: The overall concept. You sarted very good with the flow diagram. But you should also explain the diagram a bit and the flow without technical descriptions like deployments.
Then the different tools like you did: Keycloak, Oauth Proxies, Ingress
For each tool the configuration (as long as applicable for PROD and local) should be explained.
E.g. ingress routes (not the URLs, but what subroutes do i need and to which service do they direct) or e.g. the Oauth2 proxy settings. Where are they stored? How do they look like? Are they organized in a specific way or splitted, etc?
And last but not least as you already started a more concrete guide for the local deployment could be done. What is localTest.me, why do we need that. What about the specific configs, where to put them, etc.
|
@RichardLinde thanks for this PR and your great contribution 👍 |
|
For me all images are working. |
baumeister25
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your work. I really like this article as it includes the most important points and links!
Added a general documentation for using a oauth2 proxy to secure services