Skip to content

[DEN-2025] update organizer list and add 2025 placeholder#14601

Merged
mattstratton merged 5 commits intodevopsdays:mainfrom
DevOpsDays-Denver:main
Sep 27, 2024
Merged

[DEN-2025] update organizer list and add 2025 placeholder#14601
mattstratton merged 5 commits intodevopsdays:mainfrom
DevOpsDays-Denver:main

Conversation

@themightymuppet
Copy link
Copy Markdown
Contributor

I've also sent an email to info@devopsdays.org with the updates to our denver distro - thank you!

@themightymuppet themightymuppet requested a review from a team as a code owner September 19, 2024 23:39
@netlify
Copy link
Copy Markdown

netlify Bot commented Sep 19, 2024

Deploy Preview for devopsdays-web ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit d29e763
🔍 Latest deploy log https://app.netlify.com/sites/devopsdays-web/deploys/66f6194a451f19000892444f
😎 Deploy Preview https://deploy-preview-14601--devopsdays-web.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@adrianmoisey
Copy link
Copy Markdown
Member

Don't forget to update the redirect:

/denver/* /events/2024-denver/:splat 302

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this 2024 file supposed to be updated?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes 2024 should’ve been updated a while ago, it’s been out of date for a while

@mattstratton
Copy link
Copy Markdown
Member

I've updated the mailing list so this can be merged once this change has been made @themightymuppet

Don't forget to update the redirect:

/denver/* /events/2024-denver/:splat 302

@mattstratton
Copy link
Copy Markdown
Member

I was going to fix a bunch of things in this for you, but you don't have "allow edits from maintainers" so I can't :/

@themightymuppet
Copy link
Copy Markdown
Contributor Author

sorry I missed the comment about updating redirects! I just pushed that change.

Also I didn't see an option to allow edits from maintainers 😭 looks like that might be a per-pr option and I wonder if it needs to be off a branch other than main? I could add core to our org/repo if y'all would prefer to have access?

thanks for the help!

@mattstratton
Copy link
Copy Markdown
Member

mattstratton commented Sep 27, 2024

It should be set as the default (allow edits from maintainers). I think maybe the first time you set it, it will work on each PR after? Most PRs we get have it set and I’m pretty sure folks aren’t checking that box each time?

https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/working-with-forks/allowing-changes-to-a-pull-request-branch-created-from-a-fork#enabling-repository-maintainer-permissions-on-existing-pull-requests

GitHub Docs
For greater collaboration, you can allow commits on branches you've created from forks in your personal account.

@mattstratton
Copy link
Copy Markdown
Member

It’s also possibly because you submitted the PR from main - probably works better on a branch

no need to give us access and honestly it would be a pain since you can’t use a group etc :)

@mattstratton mattstratton merged commit 6c62897 into devopsdays:main Sep 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants