Skip to content

[CAI-25] Creating Cairo 2025 event#14630

Merged
nimbinatus merged 13 commits intodevopsdays:mainfrom
aameen79:main
Oct 1, 2024
Merged

[CAI-25] Creating Cairo 2025 event#14630
nimbinatus merged 13 commits intodevopsdays:mainfrom
aameen79:main

Conversation

@aameen79
Copy link
Copy Markdown
Contributor

Creating Cairo 2025 event, with logos and pages

@aameen79 aameen79 requested a review from a team as a code owner September 29, 2024 11:55
@netlify
Copy link
Copy Markdown

netlify Bot commented Sep 29, 2024

Deploy Preview for devopsdays-web ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit fb26b9f
🔍 Latest deploy log https://app.netlify.com/sites/devopsdays-web/deploys/66fbe1b951a9eb000851102a
😎 Deploy Preview https://deploy-preview-14630--devopsdays-web.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@don-code
Copy link
Copy Markdown
Collaborator

Can you also update static/_redirects to point at the 2025 event?

@aameen79
Copy link
Copy Markdown
Contributor Author

aameen79 commented Sep 29, 2024 via email

@jerdog
Copy link
Copy Markdown
Collaborator

jerdog commented Sep 29, 2024

I'm not sure if I know how to do so, I would appreciate your help for this :)

@aameen79 you would edit this line to point to the 2025 event, i.e. /events/2025-cairo/:splat

@aameen79
Copy link
Copy Markdown
Contributor Author

aameen79 commented Sep 29, 2024 via email

@aameen79
Copy link
Copy Markdown
Contributor Author

Kind reminder to book the event :)

@aameen79
Copy link
Copy Markdown
Contributor Author

Also email sent to info yesterday

@jerdog jerdog added the awaiting-email-to-info An email to info@ is pending. label Sep 30, 2024
@jerdog
Copy link
Copy Markdown
Collaborator

jerdog commented Sep 30, 2024

Core will need to verify they've updated all the things before we can merge this.

@aameen79
Copy link
Copy Markdown
Contributor Author

aameen79 commented Sep 30, 2024 via email

Copy link
Copy Markdown
Member

@nimbinatus nimbinatus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you have any trouble with making the logo-square.jpg file actually square, please let us know!

Otherwise, all global core updates have been made; once this file is squared off, then this can be merged.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi there! One last change before I can merge this as core. Can you make this image file actually square, please? You can add white space around it to make it square; no need to make a new logo or anything. It needs to be square to ensure the main page on the website loads properly.

The other logo file can be left as is.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(For reference, this patch was manually done for the 2024 file; it can be copied if that's easier: https://github.com/devopsdays/devopsdays-web/pull/14462/files#diff-fb239e5bde62db7d6567ee309d37c8813932609cb347332c5041749b19b3cc40)

@nimbinatus nimbinatus removed the awaiting-email-to-info An email to info@ is pending. label Sep 30, 2024
@aameen79
Copy link
Copy Markdown
Contributor Author

aameen79 commented Oct 1, 2024 via email

Copy link
Copy Markdown
Member

@nimbinatus nimbinatus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All changes for global core are completed. LGTM

@nimbinatus nimbinatus merged commit 2427f9a into devopsdays:main Oct 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants