Skip to content

Conversation

@shar1z
Copy link
Contributor

@shar1z shar1z commented Aug 27, 2025

  • New sponsors added - Baseshift, DevOps Leaders IL, Robusta
  • Edited sponsor page

@shar1z shar1z requested a review from a team as a code owner August 27, 2025 06:44
@netlify
Copy link

netlify bot commented Aug 27, 2025

Deploy Preview for devopsdays-web ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 5967d90
🔍 Latest deploy log https://app.netlify.com/projects/devopsdays-web/deploys/68cadd1c6881900008fb88b8
😎 Deploy Preview https://deploy-preview-15446--devopsdays-web.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@shar1z
Copy link
Contributor Author

shar1z commented Aug 27, 2025

Apologies for the many edits - I still am unable to view Hugo locally since upgrading my laptop - there's some kind of error related to templates and other stuff from other events that I can't seem to resolve.
My only way to preview is through the Netlify.

@@ -0,0 +1,2 @@
name: "devops leaders il"
url: "https://open.spotify.com/show/1D8xJvi6UMANmutW63FoNI?si=d36eb8fa4df14723"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be name: devops-leaders-il

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Euhm, the name entry isn't a real problem.
The problem is that the file name is devops-leaders-il.yml while the sponsor entry in main.yml is devops_leaders_il
You need_ to chose the same filename as well as entry, so or use underscore _ or dash -
The name is just used for image alt and in case of low bandwidth

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, another point is that the image file name should be the same as the data file name and entry in the sponsor section
You currently have devops_leaders_il.jpeg, so again be consistent in file naming

@@ -0,0 +1,2 @@
name: "devops leaders il"
url: "https://open.spotify.com/show/1D8xJvi6UMANmutW63FoNI?si=d36eb8fa4df14723"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Euhm, the name entry isn't a real problem.
The problem is that the file name is devops-leaders-il.yml while the sponsor entry in main.yml is devops_leaders_il
You need_ to chose the same filename as well as entry, so or use underscore _ or dash -
The name is just used for image alt and in case of low bandwidth

@@ -0,0 +1,2 @@
name: "devops leaders il"
url: "https://open.spotify.com/show/1D8xJvi6UMANmutW63FoNI?si=d36eb8fa4df14723"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, another point is that the image file name should be the same as the data file name and entry in the sponsor section
You currently have devops_leaders_il.jpeg, so again be consistent in file naming

@shar1z
Copy link
Contributor Author

shar1z commented Sep 17, 2025

Thanks @toshywoshy
I dropped the ball on this one - I needed to add a new sponsor - and then remembered I still had this PR festering.
Can you check now - I think I aligned all the name conventions for devops_leaders_il

@shar1z
Copy link
Contributor Author

shar1z commented Sep 17, 2025

I don't know how to resolve the issue with the image. I've changed all the files to be consistent, and the file type to jpg - not sure why it's still not showing. Let's remove them for now - and I'll try to fix, so we can merge.

@toshywoshy toshywoshy merged commit 835968e into devopsdays:main Sep 17, 2025
8 checks passed
@shar1z shar1z deleted the tlv-2025-2508-edits branch September 18, 2025 06:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants