Skip to content

Conversation

@alllomancer
Copy link
Contributor

creating an inital PR for the upcoming event

@alllomancer alllomancer requested a review from a team as a code owner September 24, 2025 17:32
@netlify
Copy link

netlify bot commented Sep 24, 2025

Deploy Preview for devopsdays-web ready!

Name Link
🔨 Latest commit ca1b917
🔍 Latest deploy log https://app.netlify.com/projects/devopsdays-web/deploys/68dea03e066fc60008fae294
😎 Deploy Preview https://deploy-preview-15504--devopsdays-web.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

Copy link
Member

@jjasghar jjasghar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a couple questions/comments.

Copy link
Member

@nimbinatus nimbinatus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Core work is complete. However, currently, your CFP does not show up on the preview (https://deploy-preview-15504--devopsdays-web.netlify.app/events/2026-prague/welcome/) other than on a single button. I've suggested some changes to make your CFP discoverable from your pages.

Also, your logo currently says 2025 on it. Is that intentional?

If those two things are intentional, then this is good to merge, but I'd highly recommend at least addressing the CFP visibility noted here.

@nimbinatus nimbinatus added the changes-requested Changes have been requested, and are pending updates. label Oct 1, 2025
alllomancer and others added 3 commits October 1, 2025 19:18
Co-authored-by: Laura Santamaria <nimbinatus@users.noreply.github.com>
Co-authored-by: Laura Santamaria <nimbinatus@users.noreply.github.com>
@nimbinatus nimbinatus dismissed stale reviews from toshywoshy and jjasghar October 2, 2025 15:49

stale - LAS

@nimbinatus nimbinatus removed the changes-requested Changes have been requested, and are pending updates. label Oct 2, 2025
Copy link
Member

@nimbinatus nimbinatus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Spacing issue (see build logs)

@nimbinatus nimbinatus merged commit 011d2ab into devopsdays:main Oct 2, 2025
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants