Updating theme to 1.22.0#5300
Merged
mattstratton merged 1 commit intomasterfrom Sep 4, 2018
Merged
Conversation
adrianmoisey
reviewed
Sep 4, 2018
| {{- with ($.Scratch.Get (printf "%s-video_link" .title)) -}} <a href="{{ . }}"><i class="fa fa-video-camera" aria-hidden="true"></i></a> {{- end -}} | ||
| {{- with ($.Scratch.Get (printf "%s-slides_link" .title)) -}} <a href="{{ . }}"><i class="fa fa-file-text-o" aria-hidden="true"></i></a> {{- end -}} | ||
| {{- end -}} | ||
| <br/> |
Member
There was a problem hiding this comment.
Is there any reason why these breaks need to be here?
Currently there's huge gaps in the blocks:
If I remove them, things look better again:
And with the icons:
They seem pointless to me, but I assume there might be a good reason to keep them.
If not, I'm happy to make a PR against the theme repo to remove them.
Member
Author
|
Yes please Pr the theme! Good catch! |
Member
|
Will do! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implemented enhancements: