Remove STONITH eviction + self-watchdog (keep poweroff)#271
Merged
Conversation
The new-CP-evicts-old-CP fencing — `kill_old_tunnels` (delete the old CP's tunnel by name prefix) and `self_watchdog` (poll CF, poweroff the old CP when its tunnel vanishes) — churned the Cloudflare tunnel hand-off, producing the 502 flap that the brittle "Verify CP health payload" deploy step trips on. On the SSH/prod path the relaunch already destroys the old CP VM before booting the new one, so the fencing was redundant there anyway. Removed: `stonith::kill_old_tunnels`, `stonith::self_watchdog`, their spawns in `cp::run`, and the broadcast/`with_graceful_shutdown` plumbing that only the watchdog drove. Kept `stonith::poweroff` (used by the fatal-boot-error paths). Orphaned old CP tunnels now linger in CF until `force-cleanup-tunnels.yml` reaps them — acceptable for now. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Simplification: rip out the STONITH fencing for now.
kill_old_tunnels+self_watchdogchurned the Cloudflare tunnel hand-off (the 502 flap during cutover that the no-retryVerify CP health payloaddeploy step fails on). On the SSH/prod path the relaunch already destroys the old CP VM before booting the new one, so the fencing was redundant.stonith::kill_old_tunnels,stonith::self_watchdog, theircp::runspawns, and the broadcast /with_graceful_shutdownplumbing only the watchdog drove.stonith::poweroff(fatal-boot-error paths still use it).force-cleanup-tunnels.ymlreaps them — acceptable for now.clippy clean, 75 tests pass.
🤖 Generated with Claude Code