Conversation
DD preview readyURL: https://pr-96.devopsdefender.com Browser login: paste CLI / curl: Register endpoint for a local agent: |
Per-PR previews (f61b453) fully replace the shared staging tier. This PR: - Adds retire-staging.yml (one-shot workflow_dispatch) to reap the leftover `dd_env=staging` VMs, `dd-staging-*` CF tunnels, and the `app-staging.{domain}` DNS CNAME. - Drops the `workflow_dispatch` trigger from release.yml — it only existed to redeploy a tag to the shared staging env. - Simplifies deploy-preview's env/OAuth branching now that PR is the only code path. - Updates README CI/CD section and the STONITH verification note. After this lands, run `retire-staging.yml` manually once, then the workflow itself can be deleted in a follow-up. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
250aea1 to
b5aff73
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Per-PR previews (from #95) fully replace the shared staging tier. This PR retires
app-staging.devopsdefender.com:retire-staging.yml— one-shotworkflow_dispatchthat deletes any lingeringdd_env=stagingVMs, CF tunnels prefixeddd-staging-, and theapp-staging.{domain}DNS CNAME. Idempotent.release.yml— drops theworkflow_dispatchtrigger (it existed only to redeploy a tag to shared staging) and simplifiesdeploy-previewnow that PR is the only codepath (no more env/OAuth ternaries).README.md— CI/CD section rewritten to describe per-PR previews; STONITH verification note updated.Rollout
After merge:
retire-staging.ymlmanually once via the Actions UIdd_env=stagingVMs,dd-staging-*tunnels, orapp-staging.{domain}DNS records remainretire-staging.ymlin a follow-up PR once rollout is confirmedTest plan
release.ymlandretire-staging.ymldeploy-previewonly triggers onpull_requestafter this changepr-{N}.devopsdefender.com(sanity-check the simplified job)retire-staging.ymland confirms cleanup🤖 Generated with Claude Code