fix(ci): teardown PR preview on branch delete, not PR close#97
Merged
Conversation
Closing a PR without deleting the branch usually means the dev might reopen — keeping the preview up is the right default. Branch delete (manual or via "delete branch on merge") is the unambiguous end-of-life signal. The delete event payload doesn't include the PR number, so the workflow looks it up from the branch name via \`gh pr list --head --state all\`. If no PR ever existed, it no-ops. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Previously
pr-teardown.ymltriggered onpull_request: closed, which deletes the preview env even when the dev plans to reopen the PR. Switch the trigger to thedeleteevent so:The
deleteevent payload has no PR number, so the workflow resolves it from the branch name viagh pr list --head <branch> --state all. If no PR ever existed for the branch, it no-ops.Test plan
🤖 Generated with Claude Code