feat: add Pennant flags for staged desktop UI rollout#107
Merged
ibourgeois merged 3 commits intomainfrom Mar 21, 2026
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Adds Laravel Pennant-based feature flags to support a staged rollout of desktop UI surfaces in Katra, establishing conventions and initial gated UI content for the desktop shell.
Changes:
- Introduces Pennant (config + migration) and desktop-scoped UI rollout feature classes (
ui.desktop.*). - Adds
App\Support\Features\DesktopUihelper and wires a first gated “Workspace navigation pilot” surface into the home controller + welcome view. - Adds Pest feature tests and updates contributor/agent docs + Boost skills metadata for Pennant.
Reviewed changes
Copilot reviewed 24 out of 25 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
composer.json |
Adds laravel/pennant dependency. |
composer.lock |
Locks Pennant and updates dependency graph. |
config/pennant.php |
Adds Pennant store configuration (array/database). |
database/migrations/2026_03_21_004800_create_features_table.php |
Adds Pennant features table migration. |
app/Features/Desktop/*.php |
Defines initial desktop UI rollout flags with ui.desktop.* naming. |
app/Support/Features/DesktopUi.php |
Central helper for scope, feature list, and flag checks. |
app/Http/Controllers/HomeController.php |
Resolves and passes desktop UI flags to the welcome view. |
resources/views/welcome.blade.php |
Conditionally shows “Workspace navigation pilot” UI section. |
tests/Feature/DesktopUiFeatureFlagTest.php |
Tests naming convention, defaults, and activation behavior. |
tests/Feature/DesktopShellTest.php |
Ensures pilot UI is hidden by default in shell. |
CONTRIBUTING.md |
Documents feature-flag conventions for desktop UI rollout. |
boost.json |
Enables Pennant skill for agent workflows. |
AGENTS.md / CLAUDE.md / GEMINI.md |
Syncs agent metadata to include Pennant. |
.junie/.github/.cursor/.claude/.agents/skills/pennant-development/SKILL.md |
Adds Pennant skill documentation across tooling directories. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
database/migrations/2026_03_21_004800_create_features_table.php
Outdated
Show resolved
Hide resolved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Testing
Closes #99