Skip to content

Write and test uint64_t generator#202

Merged
mercere99 merged 5 commits intodevosoft:masterfrom
mmore500:getuint64
Jan 29, 2019
Merged

Write and test uint64_t generator#202
mercere99 merged 5 commits intodevosoft:masterfrom
mmore500:getuint64

Conversation

@mmore500
Copy link
Copy Markdown
Member

The function GetUInt64() draws uniformly over all possible uint64_t's, analogously to the function GetUInt().

I also added some tests for GetUInt().

@codecov
Copy link
Copy Markdown

codecov Bot commented Jan 23, 2019

Codecov Report

Merging #202 into master will decrease coverage by 0.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #202      +/-   ##
==========================================
- Coverage   65.05%   65.04%   -0.02%     
==========================================
  Files          95       95              
  Lines       13153    13203      +50     
==========================================
+ Hits         8557     8588      +31     
- Misses       4596     4615      +19
Impacted Files Coverage Δ
source/tools/Random.h 54.07% <100%> (+1.04%) ⬆️
tests/test_tools.cc 99.36% <100%> (+0.02%) ⬆️
source/hardware/AvidaGP.h 40.28% <0%> (-7.11%) ⬇️
source/hardware/AvidaCPU_InstLib.h 44.11% <0%> (-2.95%) ⬇️
source/hardware/InstLib.h 34.37% <0%> (-1.57%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4002225...9914349. Read the comment docs.

Matthew Andres Moreno and others added 3 commits January 28, 2019 14:13
@mmore500
Copy link
Copy Markdown
Member Author

@mercere99 when you have a chance, I think this should be ready to merge

Copy link
Copy Markdown
Member

@mercere99 mercere99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Straightforward change -- should work well. Tests look good now.

@mercere99 mercere99 merged commit 7cb3bf9 into devosoft:master Jan 29, 2019
@mmore500 mmore500 deleted the getuint64 branch March 8, 2019 20:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants