Write and test uint64_t generator#202
Merged
mercere99 merged 5 commits intodevosoft:masterfrom Jan 29, 2019
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #202 +/- ##
==========================================
- Coverage 65.05% 65.04% -0.02%
==========================================
Files 95 95
Lines 13153 13203 +50
==========================================
+ Hits 8557 8588 +31
- Misses 4596 4615 +19
Continue to review full report at Codecov.
|
This reverts commit 73033a2.
Divide large values being summed into double before summing instead of after.
Member
Author
|
@mercere99 when you have a chance, I think this should be ready to merge |
mercere99
approved these changes
Jan 29, 2019
Member
mercere99
left a comment
There was a problem hiding this comment.
Straightforward change -- should work well. Tests look good now.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The function
GetUInt64()draws uniformly over all possibleuint64_t's, analogously to the functionGetUInt().I also added some tests for
GetUInt().