Skip to content

Add ClearProgram function to SignalGP hardware#209

Merged
mmore500 merged 4 commits intodevosoft:masterfrom
mmore500:clear-program
Feb 5, 2019
Merged

Add ClearProgram function to SignalGP hardware#209
mmore500 merged 4 commits intodevosoft:masterfrom
mmore500:clear-program

Conversation

@mmore500
Copy link
Copy Markdown
Member

I assume this also requires resetting hardware or bad things might happen? This functionality is useful if you want to have persistent traits, but need to be able to reset everything else.

@mmore500 mmore500 changed the title Add ClearProgram function Add ClearProgram function to SignalGP hardware Jan 30, 2019
@mmore500 mmore500 requested a review from amlalejini January 30, 2019 18:30
@codecov
Copy link
Copy Markdown

codecov Bot commented Jan 30, 2019

Codecov Report

Merging #209 into master will increase coverage by 0.21%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #209      +/-   ##
==========================================
+ Coverage   65.34%   65.55%   +0.21%     
==========================================
  Files          95       95              
  Lines       13203    13223      +20     
==========================================
+ Hits         8627     8668      +41     
+ Misses       4576     4555      -21
Impacted Files Coverage Δ
source/hardware/EventDrivenGP.h 54.35% <100%> (+0.23%) ⬆️
tests/test_hardware.cc 100% <100%> (ø) ⬆️
source/hardware/AvidaGP.h 48.34% <0%> (+0.94%) ⬆️
source/tools/math.h 76.42% <0%> (+3.25%) ⬆️
source/hardware/AvidaCPU_InstLib.h 85.29% <0%> (+14.7%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 61e3536...e26b28d. Read the comment docs.

@amlalejini
Copy link
Copy Markdown
Member

Yup! This looks like useful functionality to have. You're right about needing to reset the hardware. If we didn't, instruction pointers would still be pointing to now invalid places in the hardware's program.

Copy link
Copy Markdown
Member

@amlalejini amlalejini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See my previous comment!

@mmore500 mmore500 merged commit 88513ef into devosoft:master Feb 5, 2019
@mmore500 mmore500 deleted the clear-program branch March 8, 2019 20:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants