Fix path to Empirical directory#211
Merged
mercere99 merged 3 commits intodevosoft:masterfrom Feb 11, 2019
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #211 +/- ##
==========================================
+ Coverage 65.29% 65.52% +0.22%
==========================================
Files 95 95
Lines 13223 13223
==========================================
+ Hits 8634 8664 +30
+ Misses 4589 4559 -30
Continue to review full report at Codecov.
|
Member
Author
|
No code additions were made, so we should override the codecov fail. |
mercere99
approved these changes
Feb 11, 2019
Member
mercere99
left a comment
There was a problem hiding this comment.
Just a simple addition of ../ to the Empirical path in the Makefile so that the ProjectTemplate compiles in place.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
Makefilein question isexamples/ProjectTemplate/Makefile.The
EMP_DIRpath is currently listed as../../Empirical. If we want users to be able to compile the Hello World example in its current location, theEMP_DIRpath should be../../../Empirical. This is the change my PR makes. If we want the user to be able to compile the Hello World Example when the user copies theexamples/ProjectTemplateoutside of theEmpiricaldirectory (e.g., next to it), thenEMP_DIRpath should be../Empirical. Either way, the currentEMP_DIRneeds to be fixed.