Merged
Conversation
1. 알람 Response 구조에 replier 컬럼이 나오지 않는 버그를 수정하였습니다.
|
Caution Review failedThe pull request is closed. Walkthrough이 변경은 InquiryAlarmEntity(문의 알람)에 대한 지원을 추가하여 AlarmDto의 정적 팩토리 메서드에서 다형적 처리 범위를 확장합니다. InquiryAlarmDto가 새로 도입되었으며, AlarmService에서는 알람 생성 시 UserAlarmService를 통해 사용자 알람 캐시를 갱신합니다. 관련 enum 및 상수의 값도 조정되었습니다. Changes
Sequence Diagram(s)sequenceDiagram
participant Client
participant AlarmService
participant UserAlarmService
participant SSE
Client->>AlarmService: sendAlarm(…)
AlarmService->>AlarmService: save AlarmEntity
AlarmService->>UserAlarmService: refreshCacheUserAlarm(userId)
AlarmService->>SSE: sendAlarm(…)
sequenceDiagram
participant InquiryAlarmEntity
participant AlarmDto
participant InquiryAlarmDto
InquiryAlarmEntity-->>AlarmDto: fromEntity(entity)
alt entity is InquiryAlarmEntity
AlarmDto-->>InquiryAlarmDto: 생성 및 반환
else entity is CommentAlarmEntity
AlarmDto-->>CommentAlarmDto: 생성 및 반환
else
AlarmDto-->>AlarmDto: 기본 생성 및 반환
end
Possibly related PRs
Poem
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (9)
✨ Finishing Touches
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
통합 테스트 거친 뒤 Main 브랜치로 병합합니다.
Summary by CodeRabbit
신규 기능
버그 수정
기타