[Bug] Hardcoded SUPER_ADMIN_EMAIL Blocks Environment-Driven Super Admin Access

[Aditya948351]

Severity

Intermediate

Affected File & Line Number Range

src/components/admin/AdminDashboard.tsx (Line 45)

Detailed Description

The email address for the super administrator is hardcoded to a static string:

const SUPER_ADMIN_EMAIL = "admin@devpath.com";

This directly conflicts with the dynamic environment configuration variable process.env.NEXT_PUBLIC_SUPER_ADMIN_EMAIL used on the ap/page.tsx login page. Under a custom deployment (where the super admin email is changed), the dashboard controls will fail to identify the admin user correctly. This blocks critical features or lets admins demote/delete themselves by accident.

Steps to Reproduce

1. Deploy the site with NEXT_PUBLIC_SUPER_ADMIN_EMAIL set to a custom address.
2. Sign in as the super admin.
3. View the Admin Dashboard.
4. Try to manage other admins or notice that the application fails to protect your own account because the dashboard checks against admin@devpath.com.

Proposed Solution

Refactor AdminDashboard.tsx to retrieve the super admin email from the global environment variable:

const SUPER_ADMIN_EMAIL = process.env.NEXT_PUBLIC_SUPER_ADMIN_EMAIL;

Ensure fallback variables are set uniformly across all component files.

[ionfwsrijan]

@Aditya948351 ## Implementation Plan for Issue #224

1. Locate Hardcoded Email

   • Open src/components/admin/AdminDashboard.tsx
   • Find the line with: const SUPER_ADMIN_EMAIL = "admin@devpath.com";

2. Refactor to Use Environment Variable

   • Replace the hardcoded line with:

     const SUPER_ADMIN_EMAIL = process.env.NEXT_PUBLIC_SUPER_ADMIN_EMAIL;

   • Ensure fallback/default handling (if necessary) for missing env variable.

3. Uniform Environment Usage

   • Search the codebase for any other super admin email references.
   • Update all usages to reference the environment variable for consistency.

4. Documentation

   • Update documentation/README if required to specify that NEXT_PUBLIC_SUPER_ADMIN_EMAIL must be set.

5. Testing

   • Test with default and custom values of NEXT_PUBLIC_SUPER_ADMIN_EMAIL.
   • Confirm super admin access and restrictions work as expected.

6. PR & Review

   • Create a PR referencing this issue and request review.

You can assign me this issue and ill create a PR shortly

[Aditya948351]

@ionfwsrijan assigned!