fix: make Dev Card fully theme-aware for light and dark modes#292
Open
PranshuPujara wants to merge 1 commit into
Open
fix: make Dev Card fully theme-aware for light and dark modes#292PranshuPujara wants to merge 1 commit into
PranshuPujara wants to merge 1 commit into
Conversation
Author
|
Hey @Niteshagarwal01 @Aditya948351 Thanks for your time |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes : #264
Fixed the Dev Card theme inconsistency issue by replacing hardcoded dark color styles with theme-aware CSS variables in
DevCard.module.css.The Dev Card now properly adapts to both Light and Dark modes while preserving the existing UI design and layout structure.
Changes Made
avatarRingInner::afterto use a dynamic theme variable instead of a fixed dark fill.rgba(255,255,255,...)styling.:global(.dark) .cardoverride to preserve the premium dark-mode appearance.Issue Fixed
Previously, the Dev Card remained permanently dark because of hardcoded color values:
This caused the component to clash with the rest of the UI when Light Mode was enabled.
The component now responds correctly to global theme changes.
Testing
Screenshots: After needful changes
Dark theme
Light theme