Skip to content

fix(#348): remove broad allow write from leaderboard Firestore rule #387

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Aditya948351 merged 1 commit into from
May 31, 2026
+12 −4
Merged

fix(#348): remove broad allow write from leaderboard Firestore rule #387

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 12 additions & 4 deletions firestore.rules
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -113,12 +113,20 @@ service cloud.firestore {
}

// Leaderboard collection
// The broad allow write clause has been removed. It was evaluated first by
// Firestore's OR logic, making the field-restricted allow update below it
// completely unreachable, and letting any owner set arbitrary point values.
match /leaderboard/{userId} {
allow read: if true;
allow write: if (request.auth != null && request.auth.uid == userId) || isSuperAdmin(); // Owner or Super Admin can write
allow update: if request.auth != null && request.auth.uid == userId && (
(request.resource.data.diff(resource.data).affectedKeys().hasOnly(['points']))
);

// Only a superadmin (backend / Admin SDK) may create or delete entries.
allow create, delete: if isSuperAdmin();

// Owners may only touch the 'points' field. All other leaderboard
// mutations must go through the trusted backend.
allow update: if request.auth != null
&& request.auth.uid == userId
&& request.resource.data.diff(resource.data).affectedKeys().hasOnly(['points']);
}

// Resources collection
Expand Down