Skip to content

make the config file an argument #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
devpikachu merged 1 commit into from
Mar 11, 2026
Merged

make the config file an argument #2

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions Common.Build/Core/BuildContext.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,8 +10,6 @@ namespace Common.Build.Core;
[UsedImplicitly]
public class BuildContext : FrostingContext
{
private const string ConfigFileName = "buildConfig.json";

public InternalConfig InternalConfig { get; }
public SolutionConfig SolutionConfig { get; }
public ProjectConfig ProjectConfig { get; }
Expand All @@ -23,6 +21,8 @@ public BuildContext(ICakeContext context) : base(context)
var profile = context.Argument<string>("general-profile", "Release");
var version = context.Argument<string>("general-version", "12.34.56");
var skipSubstitution = context.Argument("general-skipSubstitution", false);
var solutionConfigFile = context.Argument<string>("config-solution", "buildConfig.json");
var projectConfigFile = context.Argument<string>("config-project", "buildConfig.json");

// Internal config
{
Expand All @@ -38,7 +38,7 @@ public BuildContext(ICakeContext context) : base(context)

// Solution config
{
SolutionConfig = LoadConfig<SolutionConfig>(context, Path.Combine("..", ConfigFileName));
SolutionConfig = LoadConfig<SolutionConfig>(context, Path.Combine("..", solutionConfigFile));
}

// Project picking
Expand All @@ -62,7 +62,7 @@ public BuildContext(ICakeContext context) : base(context)

// Project config
{
ProjectConfig = LoadConfig<ProjectConfig>(context, Path.Combine("..", InternalConfig.Project, ConfigFileName));
ProjectConfig = LoadConfig<ProjectConfig>(context, Path.Combine("..", InternalConfig.Project, projectConfigFile));
}
}

Expand Down