fix(security): track identifier lines linearly - #110
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Description
identifiersInSourceininternal/codeguard/checks/quality/quality_precision_workstreams_cd.goto maintain a runninglinecounter and onlystrings.Countthe non-overlapping slice between consecutive matches, making line computation linear-time.internal/codeguard/checks/quality/quality_precision_workstreams_cd_test.gowithTestIdentifiersInSourceTracksLinesto assert correct line numbers across same-line identifiers, blank lines, and subsequent line transitions.roleSuffixOveruseFinding,crossLayerInconsistencyFinding) continue to operate without behavior changes.Testing
gofmtand rango test ./internal/codeguard/checks/quality ./tests/checks, and the test suites completed successfully.go testspecifically for theinternal/codeguard/checks/qualitypackage and observed the new unit test pass.szr-wrapped test command butszris not installed in this environment, and equivalent directgo testinvocations were used instead and passed.Codex Task