Opt-in project rule discovery to prevent repo-controlled command rewrites - #85
Merged
Merged
Conversation
alxxjohn
force-pushed
the
alexj/fix-auto-loaded-project-rules-vulnerability
branch
from
August 20, 2026 16:29
7caa667 to
64ffbf2
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
rewrite.mode: "replace"to substitute arbitrary argv, allowing a malicious checkout to execute attacker-chosen commands whenszrwas run from that tree.Description
Advanced.ProjectRules(JSONadvanced.project_rules) that isfalseby default and documents that project rules can rewrite executed commands.LoadWithunlessAdvanced.ProjectRulesis enabled so repository.szrfiles are ignored by default.settingsProjectRulesAction) to let users enableproject rulesvia thesettingsmenu and persist the choice.internal/config/config.go,internal/cli/settings.go,internal/cli/settings_filters.go,test/config/project_rules_test.go,test/cli/settings_filters_test.go, anddocs/ARCHITECTURE.md.Testing
gofmtbefore running tests.go test ./test/config ./test/cli ./test/engine ./test/rulesand thengo test ./..., and all tests completed successfully.advanced.project_rules, and those tests passed.Codex Task