feat(gitflow): add GitFlow workflow and migrate to devran-ai org#1
feat(gitflow): add GitFlow workflow and migrate to devran-ai org#1emredursun merged 3 commits intodevfrom
Conversation
…anch - Create dev branch as integration target for all feature work - Update CI pipeline to run on both main and dev branches - Add PR template with conventional commit checklist - Rewrite git-workflow rules with full GitFlow branch strategy - Update CONTRIBUTING.md with GitFlow workflow documentation - Update /pr workflow to auto-detect GitFlow and target dev
Update all repository references across 17 files: - package.json, manifest.json: repository URL - README, CONTRIBUTING, docs: GitHub links - mkdocs.yml, robots.txt: GitHub Pages URLs - bin/ag-kit.js, create-antigravity-app: CLI output URLs
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request introduces the GitFlow workflow, migrates the repository to the Highlights
Ignored Files
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request introduces a GitFlow branching strategy and migrates all repository URLs to the new devran-ai organization. The changes are extensive, touching many documentation and configuration files. The new GitFlow process is well-documented. I've found a few areas in the documentation that could be improved for clarity and correctness. Specifically, there's an incorrect command in the getting started guide, some ambiguity in the hotfix process documentation, and an inconsistency in the contributing guide's examples.
docs/getting-started.md
Outdated
| git clone https://github.com/devran-ai/kit.git | ||
|
|
||
| # 2. Copy .agent/ to your project | ||
| cp -r antigravity-ai-kit/.agent/ your-project/.agent/ |
There was a problem hiding this comment.
The git clone command on line 38 now clones the repository into a directory named kit. However, this cp command still references the old directory name antigravity-ai-kit. This will cause the command to fail for anyone following the manual installation instructions.
| cp -r antigravity-ai-kit/.agent/ your-project/.agent/ | |
| cp -r kit/.agent/ your-project/.agent/ |
.agent/rules/git-workflow.md
Outdated
| 1. Create `hotfix/*` branch from `main` | ||
| 2. Fix the issue with minimal changes | ||
| 3. Create PR targeting `main` | ||
| 4. After merge, cherry-pick or merge `main` into `dev` |
There was a problem hiding this comment.
The instruction "cherry-pick or merge main into dev" is a bit ambiguous. To ensure a consistent and clear workflow, it's better to be prescriptive. The release process already specifies merging main back into dev. Aligning the hotfix process with this would improve clarity.
| 4. After merge, cherry-pick or merge `main` into `dev` | |
| 4. After merge, merge `main` back into `dev` to sync the hotfix. |
CONTRIBUTING.md
Outdated
| ## Overview | ||
| ... | ||
| ``` | ||
| 1. Create `.agent/skills/your-skill/SKILL.md` with frontmatter |
There was a problem hiding this comment.
This instruction is less helpful without the example frontmatter that was previously here. For consistency with the "Adding an Agent" section and to help contributors, consider restoring the example, like so:
1. Create `.agent/skills/your-skill/SKILL.md` with frontmatter:
```markdown
---
name: your-skill
description: What this skill does
triggers: [keyword1, keyword2]
---
# Your Skill
## Overview
...
CONTRIBUTING.md
Outdated
| --- | ||
| # Steps... | ||
| ``` | ||
| 1. Create `.agent/workflows/your-workflow.md` with frontmatter |
There was a problem hiding this comment.
Similar to the "Adding a Skill" section, this instruction is less helpful without the example frontmatter. For consistency and clarity, please consider restoring the example:
1. Create `.agent/workflows/your-workflow.md` with frontmatter:
```markdown
---
description: What this workflow does
---
# Steps...
- Fix HIGH: docs/getting-started.md cp command references old dir name - Fix MEDIUM: git-workflow.md hotfix merge instruction clarified - Fix MEDIUM: CONTRIBUTING.md restore skill/workflow frontmatter examples
* feat(gitflow): add GitFlow branching strategy with dev integration branch - Create dev branch as integration target for all feature work - Update CI pipeline to run on both main and dev branches - Add PR template with conventional commit checklist - Rewrite git-workflow rules with full GitFlow branch strategy - Update CONTRIBUTING.md with GitFlow workflow documentation - Update /pr workflow to auto-detect GitFlow and target dev * chore: migrate repository URLs from besync-labs to devran-ai/kit Update all repository references across 17 files: - package.json, manifest.json: repository URL - README, CONTRIBUTING, docs: GitHub links - mkdocs.yml, robots.txt: GitHub Pages URLs - bin/ag-kit.js, create-antigravity-app: CLI output URLs * fix: address gemini-code-assist review findings on PR #1 - Fix HIGH: docs/getting-started.md cp command references old dir name - Fix MEDIUM: git-workflow.md hotfix merge instruction clarified - Fix MEDIUM: CONTRIBUTING.md restore skill/workflow frontmatter examples * chore: remove node_modules from git tracking - Untrack 917 node_modules files (were committed before .gitignore rule) - Delete npm-publish-output.txt build artifact - Add npm-publish-output.txt to .gitignore - CI should run npm install instead of relying on committed deps * feat!: rebrand to @devran-ai/kit v4.0.0 and optimize framework tokens BREAKING CHANGES: - Package renamed: antigravity-ai-kit → @devran-ai/kit - CLI command renamed: ag-kit → kit - Scaffolder renamed: create-antigravity-app → create-kit-app Rebranding (127 files): - Full rename across package.json, CLI, lib/, docs/, .agent/, tests/ - README rewritten for enterprise clarity (758 → 120 lines) - Removed node_modules from git tracking (917 files, 236K lines) - Deleted documentation bloat (archive docs, operational guides) Framework token optimization (56% reduction, 262K chars saved): - Workflows: 125K → 63K (50% reduction, all under 10K chars) - Agents: 273K → 114K (58% reduction, all under 10K chars) - Skills: 78K → 26K (67% reduction for top 5 offenders) - Extracted shared rules to workflow-standards.md - Removed textbook content AI already knows - Deduplicated governance sections across 22 workflows All 348 tests passing. * fix: address gemini-code-assist review findings on PR #2 - Fix 3 frontmatter descriptions exceeding 250-char limit - Standardize agent titles: remove redundant "Devran AI Kit —" prefix - Fix CHANGELOG wording: clarify node_modules untracking vs deletion - Add token optimization entry to CHANGELOG * fix: update architecture diagram version to v4.0.0 The ASCII diagram header still showed v3.8.0 after the rebrand. * feat: Devran AI Kit v4.1.0 — cross-IDE support, multi-language reviewers, enhanced DX * feat: Devran AI Kit v4.1.0 — cross-IDE support, multi-language reviewers, enhanced DX Phase 1 — Cross-IDE Config Generation: - New lib/ide-generator.js (zero-dep, pure functions, transactional writes) - kit init generates Cursor (.mdc), OpenCode (.json), Codex (.toml) configs - kit update regenerates IDE configs non-destructively - create-kit-app scaffolder includes IDE configs - ADR-002 documents architectural decision - 18 new tests (path traversal, secret detection, format validation) Phase 2 — Multi-Language Reviewers: - typescript-reviewer.md (strict mode, no any, generics, satisfies) - python-reviewer.md (PEP 8, mypy strict, async, Pydantic) - go-reviewer.md (error wrapping, goroutine leaks, context.Context) - Count synced across 8+ files (manifest, README, CheatSheet, docs, loading-rules) - Orchestrate dynamicAgentPool updated with new reviewers Phase 3 — Enterprise README: - Full rewrite with comparison table, badges, CLI reference - "Why Devran AI Kit?" differentiation section - Cross-IDE support table, v4.1.0 highlights Phase 4 — GitHub Community: - FUNDING.yml, CODE_OF_CONDUCT.md (Contributor Covenant v2.1) - Enhanced PR template (IDE impact, manifest sync checkboxes) - Enhanced issue templates (IDE dropdown, version field) Phase 5 — Enhanced Continuous Learning: - New lib/learning-engine.js (confidence scoring, clustering, decay) - Netflix-inspired feedback loop: observe → score → cluster → promote → decay - 16 new tests with input validation hardening Phase 6 — MCP Server Templates: - 5 pre-configured templates (GitHub, Supabase, Vercel, Filesystem, PostgreSQL) - ${VAR} placeholders for secrets (no hardcoded values) - IDE generator transforms templates into IDE-native MCP format Phase 7 — Documentation: - docs/faq.md, docs/cli-reference.md, docs/cross-ide-setup.md - Enhanced landing page with v4.1.0 highlights - mkdocs.yml nav updated Security hardening (from Tier-1 audit): - Null-byte rejection in path validation (H-1) - Input type/range validation on all learning-engine functions (H-2) - Parameter type validation on writeIdeConfigs (M-3) Verification: 382/382 tests passing, kit verify 127/0, kit scan 0 critical/0 high * fix: address Tier-1 code review findings (3 HIGH, 3 MEDIUM) HIGH-1: Use CURSOR_DIR/OPENCODE_DIR/CODEX_DIR constants instead of hardcoded path strings in ide-generator.js — prevents drift. HIGH-2: Extract atomicWriteFile() and rollbackWrittenFiles() helpers from writeIdeConfigs — each function now under 50 lines. HIGH-3: Fix TOML serializer for mixed scalar/object sections — emit [section] header once for scalars, then subsections separately. MEDIUM-4: Remove dead code — duplicate skip logic in writeIdeConfigs. MEDIUM-5: Freeze module.exports with Object.freeze for consistency. H-2 hardening: Add Array.isArray guards + Number.isFinite validation to learning-engine.js clusterPatterns and decayPatterns. * docs: add safety guarantees, agents listing, operating constraints to README Restores critical DX sections from the old Antigravity AI Kit README: - Safety Guarantees table (which project files are never touched) - init --force safety features (backup, atomic copy, symlink guard) - update preserved files list (session data, ADRs, rules, contexts) - Agents table grouped by category (23 agents across 6 categories) - Operating Constraints table (5 immutable principles) - Repository structure tree - Author section - Enhanced Quick Start with both options (create new + add to existing) - Getting Started docs page updated with same safety details * fix: address gemini-code-assist review findings on PR #3 H-1: Add JSDoc scope doc + array support to TOML serializer — zero-dep design decision documented, not incomplete by accident. M-1: Extract generateIdeConfigsForInit() helper from initCommand — reduces function length and improves readability. M-2: Replace hardcoded protocol names with generic regex pattern — auto-discovers all "### A. ..." sections from rules.md. M-3: Use finally block in atomicWriteFile for guaranteed temp cleanup — prevents orphaned .tmp files on non-transient errors. M-4: Use exact keyword matching (===) instead of includes() in clusterPatterns — prevents false positives (e.g., "test" matching "contest"). * fix: correct LinkedIn URL in Author section * fix: address gemini-code-assist review #3988546877 findings M-1: Fail explicitly on unknown --ide value instead of silently generating all configs. Lists supported IDEs in error message. M-2: Log error message in create-kit-app IDE config catch block instead of silently swallowing errors. M-3: Log error message in updater IDE config catch block for better debugging and maintainability.
1 participant
Summary
devas integration branch andmainas production-onlybesync-labs/antigravity-ai-kittodevran-ai/kit(17 files)mainanddevbranchesType of Change
feat— New featurechore— URL migrationBreaking Changes
Test Plan
npm testpasses locally (34 files, 348 tests green)besync-labsreferences updated (1 historical CHANGELOG entry preserved)Files Changed (22 files)
GitFlow Infrastructure:
.github/workflows/ci.ymldevto push/PR branch triggers.github/PULL_REQUEST_TEMPLATE.md.agent/rules/git-workflow.md.agent/workflows/pr.mddevby defaultCONTRIBUTING.mdURL Migration (17 files):
package.json,manifest.json,README.md,CONTRIBUTING.md,CHANGELOG.md,mkdocs.yml,bin/ag-kit.js,docs/*,create-antigravity-app/*,.agent/skills/i18n-localization/SKILL.mdChecklist
besync-labsreferences remain (except 1 historical CHANGELOG note)