Skip to content

virtualbox improvements#166

Merged
devrandom merged 6 commits intomasterfrom
vbox
Mar 3, 2018
Merged

virtualbox improvements#166
devrandom merged 6 commits intomasterfrom
vbox

Conversation

@devrandom
Copy link
Copy Markdown
Owner

@devrandom devrandom commented Feb 13, 2018 •
edited
Loading

In this PR:

  • default VirtualBox launches to headless
  • support debian VirtualBox via Vagrant Cloud images
  • Debian on LXC should also work, for hosts that support LXC well (Ubuntu 17.10 has a bug in lxc-execute)
  • git submodule support - any submodules are cloned and checked out before the build

@josephbisch
Copy link
Copy Markdown
Collaborator

josephbisch commented Feb 17, 2018

I can't get it to work. I never used VirtualBox with Gitian in the first place though.

 joseph@arch_laptop  ~/git/gitian-builder   vbox  start-target 64 xenial-amd64
Waiting for VM "Gitian-xenial-amd64" to power on...
VM "Gitian-xenial-amd64" has been successfully started.
 joseph@arch_laptop  ~/git/gitian-builder   vbox  on-target ls -la
ssh: connect to host localhost port 2223: Connection refused

I got in via ssh when setting it up. Maybe I didn't make the snapshot correctly.

@devrandom
Copy link
Copy Markdown
Owner Author

devrandom commented Feb 19, 2018

Using the VirtualBox Manager GUI, you can check if network port for SSH is forwarded. You can also look at the console in the UI and see if it's at the login prompt or if it had some boot issue.

Also, make sure you are waiting long enough (should be about 30 seconds from start).

@devrandom
Copy link
Copy Markdown
Owner Author

devrandom commented Feb 19, 2018

(the network forward can be see in machine settings under Network tab, Advanced section, Port Forwarding button)

@josephbisch
Copy link
Copy Markdown
Collaborator

josephbisch commented Feb 20, 2018

Thanks, it just worked today for some reason. I didn't change anything. So I tested Ubuntu Xenial amd64 guest (just sanity test). I didn't test with a Debian guest, but I'll leave comments about Debian guests.

josephbisch
josephbisch reviewed Feb 20, 2018
View reviewed changes
Comment thread bin/make-base-vm

vagrant up "$NAME"
if [ $DISTRO_USER_CREATE = "1" ]; then
vagrant ssh "$NAME" -c "sudo useradd -m -s /bin/bash $DISTRO"
Copy link
Copy Markdown
Collaborator

@josephbisch josephbisch Feb 20, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you need to also add the $DISTRO user to sudoers?

Copy link
Copy Markdown
Owner Author

@devrandom devrandom Feb 20, 2018 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's done in gbuild already (although I'm not convinced that's the best place).

@devrandom
Copy link
Copy Markdown
Owner Author

devrandom commented Mar 3, 2018

@josephbisch ping

@josephbisch
Copy link
Copy Markdown
Collaborator

josephbisch commented Mar 3, 2018

pong

Still haven't tried Debian guests, but LGTM. So if you tried Debian guests, feel free to merge.

@devrandom devrandom merged commit d0127cc into master Mar 3, 2018
devrandom added a commit that referenced this pull request Mar 3, 2018
@devrandom
Merge #166: virtualbox improvements
d520618 
d0127cc Release notes (Devrandom)
923c711 add CODEOWNERS (Devrandom)
cac395d git submodule support (Devrandom)
496f45d support Debian / virtualbox via Vagrant Cloud (Devrandom)
ead388a headless vbox (Devrandom)
7338dc5 do not complain about kvm if in VBOX mode (Devrandom)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@josephbisch josephbisch josephbisch approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@devrandom @josephbisch