Add attachment deduplication checks for both ID and Parent ID#131
Merged
gasperzgonec merged 9 commits intomainfrom Feb 12, 2026
Merged
Add attachment deduplication checks for both ID and Parent ID#131gasperzgonec merged 9 commits intomainfrom
gasperzgonec merged 9 commits intomainfrom
Conversation
radovanjorgic
requested changes
Jan 23, 2026
Collaborator
There was a problem hiding this comment.
Fix title of the PR to be in present tense and without dot at the end. Also, please test with template. Once we resolve comments please release beta (maybe from branch first) and connect with Purva (or whoever is the developer) to test it out on his connector.
radovanjorgic
changed the title
…sedAttachment format.
radovanjorgic
approved these changes
Feb 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Before this change, the attachments from different parents that had the same ID were deduplicated and not pushed. Now, we take the parent ID into the consideration when pushing, so that attachments with the same ID and different parent ID will still be uploaded.
Connected Issues
Checklist
npm run testOR no tests needed.npm run test:backwards-compatibility.npm run lint.