Fix attachment streaming errors and add observability for failed attachments#136
Merged
gasperzgonec merged 26 commits intomainfrom Feb 27, 2026
Merged
Fix attachment streaming errors and add observability for failed attachments#136gasperzgonec merged 26 commits intomainfrom
gasperzgonec merged 26 commits intomainfrom
Conversation
Before, some error messages contained [object Object], so I had to add JSON.stringify(<error>) to fix that. I changed `. "+error` to `.", error`, which automatically adds a space and stringifies the error.
gasperzgonec
changed the title
Co-authored-by: Radovan Jorgić <radovanjorgic14@gmail.com>
Fixed backward compatibility by updating the latest.json with one generated with the new api-extractor on origin/main. Updated a few iffy callpoints and conditions.
We have been checking for the `isTimeout` in the `processAttachment`, which caused us to exit the function processing early and we were catching that, as we wouldn't have been able to finish processing the following attachments. I've removed that check, so now we can still finish processing the attachments that are still in store, as underlying functions don't really have checks for the `isTimeout`.
radovanjorgic
approved these changes
Feb 27, 2026
Collaborator
radovanjorgic
left a comment
radovanjorgic
left a comment
There was a problem hiding this comment.
Can you please re-check serializeError is used across the codebase (or at least in files related to attachments for now) and it is not double stringified anywhere.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes the following issues:
Connected Issues
Checklist
npm run testOR no tests needed.npm run test:backwards-compatibility.npm run lint.