Add external domain metadata interface#146
Conversation
B-Lorentz
left a comment
There was a problem hiding this comment.
Largely LGTM, was this generated by a deterministic tool from the jsonschema, or by AI?
It would however be helpful to have some tests, that show that the data accepted by these type declarations is the same as by the schema, and the other way around
This was generated by AI. I tried using some tool like json-schema-to-typescript, but AI version was muche better from all perspectives: size, readability, naming and so on. |
ftopic
left a comment
There was a problem hiding this comment.
There are some things that we shouldn't expose since they are deprecated but otherwise LGTM
1eb868a
|
You're missing a |
Description
This PR adds export of the
ExternalDomainMetadatainterface and all of its types.Connected Issues
https://app.devrev.ai/devrev/works/ISS-263582
Checklist
npm run testOR no tests needed.npm run test:backwards-compatibility.npm run lint.