Skip to content

Add external domain metadata interface#146

Merged
radovanjorgic merged 8 commits intomainfrom
rado/edm-interface
Feb 26, 2026
Merged

Add external domain metadata interface#146
radovanjorgic merged 8 commits intomainfrom
rado/edm-interface

Conversation

@radovanjorgic
Copy link
Copy Markdown
Collaborator

@radovanjorgic radovanjorgic commented Feb 25, 2026

Description

This PR adds export of theExternalDomainMetadata interface and all of its types.

Connected Issues

https://app.devrev.ai/devrev/works/ISS-263582

Checklist

  • Tests added/updated and ran with npm run test OR no tests needed.
  • Ran backwards compatibility tests with npm run test:backwards-compatibility.
  • Code formatted and checked with npm run lint.
  • Tested airdrop-template linked to this PR.
  • Documentation updated and provided a link to PR / new docs OR no docs needed.

@radovanjorgic radovanjorgic marked this pull request as ready for review February 25, 2026 07:15
@radovanjorgic radovanjorgic requested review from a team and gasperzgonec as code owners February 25, 2026 07:15
gasperzgonec
gasperzgonec previously approved these changes Feb 25, 2026
B-Lorentz
B-Lorentz previously approved these changes Feb 26, 2026
Copy link
Copy Markdown

@B-Lorentz B-Lorentz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Largely LGTM, was this generated by a deterministic tool from the jsonschema, or by AI?
It would however be helpful to have some tests, that show that the data accepted by these type declarations is the same as by the schema, and the other way around

Comment thread src/types/external-domain-metadata.ts
Comment thread src/types/external-domain-metadata.ts Outdated
@radovanjorgic
Copy link
Copy Markdown
Collaborator Author

Largely LGTM, was this generated by a deterministic tool from the jsonschema, or by AI?

This was generated by AI. I tried using some tool like json-schema-to-typescript, but AI version was muche better from all perspectives: size, readability, naming and so on.

Copy link
Copy Markdown

@ftopic ftopic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are some things that we shouldn't expose since they are deprecated but otherwise LGTM

Comment thread src/types/external-domain-metadata.ts Outdated
Comment thread src/types/external-domain-metadata.ts
Comment thread src/types/external-domain-metadata.ts Outdated
Comment thread src/types/external-domain-metadata.ts
Comment thread src/types/external-domain-metadata.ts Outdated
@radovanjorgic radovanjorgic dismissed stale reviews from B-Lorentz and gasperzgonec via 1eb868a February 26, 2026 11:28
B-Lorentz
B-Lorentz previously approved these changes Feb 26, 2026
Comment thread src/types/external-domain-metadata.ts
B-Lorentz
B-Lorentz previously approved these changes Feb 26, 2026
ftopic
ftopic previously approved these changes Feb 26, 2026
@gasperzgonec
Copy link
Copy Markdown
Contributor

You're missing a json file in the root of the project, that makes the tests fail.

@radovanjorgic radovanjorgic dismissed stale reviews from ftopic and B-Lorentz via a89e093 February 26, 2026 13:03
@radovanjorgic radovanjorgic merged commit f0f225c into main Feb 26, 2026
8 checks passed
@radovanjorgic radovanjorgic deleted the rado/edm-interface branch February 26, 2026 13:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants