Fix the events present in the template #28
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gasperzgonec
requested review from
a team,
patricijabrecko and
radovanjorgic
as code owners
This was referenced Oct 13, 2025
gasperzgonec
added a commit
that referenced
this pull request
Oct 14, 2025
Review #28 before this one. ## Summary One of last week's action point was to ensure worker file split that is native for DevRev's snap-in development. Example from Asana https://github.com/devrev/airdrop-asana-snap-in/blob/7f2e49e906a9b3e3c7d13b3391fdb588dec2ad7b/code/src/functions/extraction/index.ts#L36-L55 Note that this is just suggestion (not a snap-in expert 😁). Curious to hear your suggestions. - [#ISS-217157](https://app.devrev.ai/devrev/works/ISS-217157) --------- Co-authored-by: gasperzgonec <gasper.zgonec@devrev.ai>
gasperzgonec
added a commit
that referenced
this pull request
Oct 14, 2025
Review #28 and #29 first. ## Summary While reviewing Wrike and Aha! specification, I noticed that there's a couple commonalities that can be abstracted into template. Most notably: - Sentence to "not stringify error message" is put in shared - Template `data_fetching_return_expectations.plain` - Acceptance test template for testing external sync units - Template for "The {{ provider_name }} Internal client" - [#ISS-217157](https://app.devrev.ai/devrev/works/ISS-217157) --------- Co-authored-by: gasperzgonec <gasper.zgonec@devrev.ai>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was two unrelated events thrown together.
I've replaced the incorrect one with the correct one.
Issues