Simplify template writing #30
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tjazerzen
requested review from
a team,
gasperzgonec,
patricijabrecko and
radovanjorgic
as code owners
gasperzgonec
requested changes
Oct 14, 2025
Co-authored-by: gasperzgonec <gasper.zgonec@devrev.ai>
gasperzgonec
approved these changes
Oct 14, 2025
gasperzgonec
pushed a commit
that referenced
this pull request
Oct 14, 2025
Review #27, #29, #30 first. ## Summary A small detail of the rate limiting proxy had to be adopted for every 3rd party service provider. After discussion with Gasper and Patricija, we're moving this away from shared and into 3rd party service-specific snap-in repos. - [#ISS-217157](https://app.devrev.ai/devrev/works/ISS-217157)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Review #28 and #29 first.
Summary
While reviewing Wrike and Aha! specification, I noticed that there's a couple commonalities that can be abstracted into template.
Most notably:
Sentence to "not stringify error message" is put in shared
Template
data_fetching_return_expectations.plainAcceptance test template for testing external sync units
Template for "The {{ provider_name }} Internal client"
#ISS-217157