Skip to content

Add stylistic lint checks to skill validate (#42)#62

Merged
devrimcavusoglu merged 2 commits intomainfrom
feature/stylistic-lint
Mar 7, 2026
Merged

Add stylistic lint checks to skill validate (#42)#62
devrimcavusoglu merged 2 commits intomainfrom
feature/stylistic-lint

Conversation

@devrimcavusoglu
Copy link
Owner

Summary

  • Add SeverityHint for non-blocking stylistic suggestions (distinct from errors/warnings)
  • Add lintStyle() with 3 checks: body too short (<20 words), description too vague (<3 words), body lacks step-by-step structure
  • Track hints separately in CLI output with ~ prefix and dedicated count
  • HasErrors() correctly ignores hints

Test plan

  • make lint && make test passes
  • TestLintStyle_BodyTooShort, TestLintStyle_DescriptionTooVague, TestLintStyle_BodyLacksSteps, TestLintStyle_NoHints
  • TestHasErrors includes "hints only" case
  • TestValidate_ValidSkill updated with a well-formed body

Closes #42

🤖 Generated with Claude Code

devrimcavusoglu and others added 2 commits March 7, 2026 11:21
- Add SeverityHint for non-blocking style suggestions
- Add lintStyle() with 3 checks: body too short, description too vague, body lacks step structure
- Track hints separately from errors/warnings in CLI output
- Add ~ prefix for hint display in text output

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@devrimcavusoglu
Copy link
Owner Author

Verified:

  • make lint && make test — 0 lint issues, all packages pass
  • 4 unit tests pass: TestLintStyle_BodyTooShort, _DescriptionTooVague, _BodyLacksSteps, _NoHints
  • TestHasErrors "hints only" case confirms hints don't count as errors
  • TestValidate_ValidSkill updated with 20+ word body — no issues
  • Added 2 missing CLI-level tests in follow-up commit: TestSkillValidate_HintsJSON (verifies hints count in JSON, Valid=true) and TestSkillValidate_HintsText (verifies "hint(s)" summary and ~ prefix)

@devrimcavusoglu devrimcavusoglu merged commit 319fae2 into main Mar 7, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Extend skill validate with stylistic lint checks

1 participant