Add comprehensive unit tests for deploy/impl modules and fix related …#88
Merged
rsonghuster merged 1 commit intomasterfrom Sep 24, 2025
Merged
Add comprehensive unit tests for deploy/impl modules and fix related …#88rsonghuster merged 1 commit intomasterfrom
rsonghuster merged 1 commit intomasterfrom
Conversation
…issues This commit adds comprehensive unit tests for all major classes in the src/subCommands/deploy/impl directory, significantly improving test coverage: 1. Added complete unit tests for AsyncInvokeConfig class (async_invoke_config.ts) 2. Added complete unit tests for ConcurrencyConfig class (concurrency_config.ts) 3. Added complete unit tests for CustomDomain class (custom_domain.ts) 4. Added complete unit tests for ProvisionConfig class (provision_config.ts) 5. Added complete unit tests for Service class (function.ts) Key improvements made: - Fixed module import paths in test files - Resolved mockResolvedValue call issues with proper parameter handling - Addressed type mismatch problems in test data structures - Fixed private method access in tests using type assertions - Corrected logger mock implementations to match actual logger interface - Fixed credentials property name inconsistencies (credentials → credential) - Resolved various other test-related issues Test coverage for deploy/impl directory improved from very low to 70.78%, with individual files achieving: - async_invoke_config.ts: 85.18% - concurrency_config.ts: 84.61% - custom_domain.ts: 88.6% - function.ts: 66.35% - provision_config.ts: 91.66% All 482 tests are now passing successfully.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…issues
This commit adds comprehensive unit tests for all major classes in the src/subCommands/deploy/impl directory, significantly improving test coverage:
Key improvements made: