Depreciated code: $dimensionsString block is never used

[piyush140104]

Description

While reading the code in yaml-generation/generateDimensions.php, I noticed that $dimensionsString is created and processed in lines 166-174 but is never actually used anywhere after that.The main variable that stores our model.yaml content is $modelString which is what gets saved to the file on line 197 not $dimensionsString.

Fix

Lines 166-174 can be safely deleted. The output will remain exactly the same.

How I verified

Searched for $dimensionsString across all files it only exists within those dead lines.

[piyush140104]

Hey @vbakke, when you have a moment can you please tell if this is intentional or not?

[vbakke]

Thank you, @piyush140104. That seems to be a merge error. Lines 166-174 are duplicated by the actual working lines 186-193.

Feel free to remove these.

[piyush140104]

Thank you @vbakke, I have raised the PR for this. Please have a look when you get a chance!