Skip to content

Minor test fixes #184

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
wurstbrot merged 1 commit into from
Nov 6, 2022
Merged

Minor test fixes #184

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/app/component/task-description/task-description.component.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -145,7 +145,7 @@ <h1>
<mat-expansion-panel>
<mat-expansion-panel-header>
<mat-panel-title>
<b>OWASP SAMM VERSION 2</b>
<b>{{ SAMMVersion }}</b>
</mat-panel-title>
</mat-expansion-panel-header>
<ul *ngFor="let samm of currentTask.samm">
Expand All @@ -155,7 +155,7 @@ <h1>
<mat-expansion-panel>
<mat-expansion-panel-header>
<mat-panel-title>
<b>ISO27001 2017</b>
<b>{{ ISOVersion }}</b>
</mat-panel-title>
</mat-expansion-panel-header>
<ul *ngFor="let iso of currentTask.iso">
Expand Down
5 changes: 2 additions & 3 deletions src/app/component/task-description/task-description.component.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -110,11 +110,11 @@ describe('TaskDescriptionComponent', () => {
fixture.detectChanges();
const HTMLElement: HTMLElement = fixture.nativeElement;
const contentDisplayedinParagraphTag = HTMLElement.querySelectorAll('p')!;
console.log(contentDisplayedinParagraphTag);
expect(contentDisplayedinParagraphTag[10].textContent).toContain(
testComments
);
});

it('check if references is being genenrated', () => {
const testSAMM = [' Sample SAMM '];
const testISO = [' Sample ISO'];
Expand All @@ -123,9 +123,8 @@ describe('TaskDescriptionComponent', () => {
fixture.detectChanges();
const HTMLElement: HTMLElement = fixture.nativeElement;
const contentDisplayedinParagraphTag = HTMLElement.querySelectorAll('p')!;
console.log(contentDisplayedinParagraphTag);
expect(contentDisplayedinParagraphTag[9].textContent).toContain(
'OWASP SAMM VERSION 2' + testSAMM[0] + 'ISO27001 2017' + testISO[0]
component.SAMMVersion + testSAMM[0] + component.ISOVersion + testISO[0]
);
});
});
3 changes: 2 additions & 1 deletion src/app/component/task-description/task-description.component.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,7 +67,8 @@ export class TaskDescriptionComponent implements OnInit {
KnowledgeLabels: string[] = [];
rowIndex: number = 0;
markdown: md = md();

SAMMVersion: string = 'OWASP SAMM VERSION 2';
ISOVersion: string = 'ISO27001 2017';
@ViewChildren(MatAccordion) accordion!: QueryList<MatAccordion>;
constructor(private route: ActivatedRoute, private yaml: ymlService) {}

Expand Down