Add in filter for team list filtering via a pipe#267
Merged
wurstbrot merged 7 commits intodevsecopsmaturitymodel:masterfrom Feb 1, 2024
Merged
Conversation
jdsmithit
changed the title
wurstbrot
approved these changes
Jan 31, 2024
Contributor
Author
|
Ill move this to draft until i have manage to sort out the commit signing issue |
jdsmithit
force-pushed
the
add-in-pipes-and-task-list-filtering
branch
from
eb26ec4 to
0221344
Compare
Contributor
Author
|
done |
Delete extra pile directory
0x41head
approved these changes
Jan 31, 2024
Collaborator
0x41head
left a comment
0x41head
left a comment
There was a problem hiding this comment.
LGTM! Thank you for the change.
Collaborator
|
Thank you, very cool ❤️ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
When you have a lot of teams ie 30+ and 7 plus groups the Ui becomes very clunky as the checkbox list is not filtered with the teams and groups.
Change:
A new enhancement to add in filtering the checkbox list, Also added a message when no teams are selected for a better user flow with this enhancement.
Design Considerations
Note: to stop this from breaking any functionality I have chosen to hide the check boxes and not remove items from the object.
Used a pipe to get the string value into the mat component checkbox and made it generic.
Testing
Preview and Testing below,