docs(profile): drop verbose label= from ssrf-guard / api-log badges#9
Merged
Conversation
Follow-up to #6 — matches the label-simplification pattern just applied to devslab-examples#59 (badge labels) and the easy-paging starter docs PR. User flagged that the long `label=kr.devslab:<artifact>` made the version text render small. Changes: - ssrf-guard badge: drop `?label=kr.devslab%3Assrf-guard` → default "Maven Central | 3.1.0" rendering - api-log-core badge: drop `?label=kr.devslab%3Aapi-log-*` → default "Maven Central | 3.0.0" rendering (api-log was renumbered 0.6.0 → 3.0.0; badge picked it up automatically — proving the auto- update value of the badge pattern) - easy-paging easy-paging dual badge: KEEPS the short labels `Spring Boot 4` / `SB3 maintenance`. Reason: that entry has TWO badges side-by-side on the same line — without a distinguishing label, readers can't tell which is the SB4 line and which is the SB3 maintenance line. The labels are short enough that the version text still renders at a readable size. Trade-off captured: the rule "default label" is broken for the dual-badge case in favor of "label that distinguishes the two side-by- side badges." Single-badge entries take the default; entries with ambiguity get a short discriminator. Both languages updated symmetrically.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Follow-up to #6 — matches the label simplification just applied to the still-open badge PRs:
User flagged that `?label=kr.devslab%3A` makes the badge's left side too long, shrinking the version text on the right.
Changes
Why easy-paging keeps its labels
The easy-paging entry is the only one with two badges on the same line (SB4 active + SB3 maintenance). Without a distinguishing label they'd both render as just "Maven Central | X.Y.Z" — readers couldn't tell which is which without clicking through. The current labels `Spring Boot 4` / `SB3 maintenance` are short enough that the version text still reads cleanly.
Single-badge rows (ssrf-guard, api-log) don't have this ambiguity → default label is fine.
Why the artifact ID being redundant is OK
Test plan