Skip to content

contribution api limit problem solved-1 #80

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
zonayedpca merged 1 commit into from
Nov 28, 2018
Merged

contribution api limit problem solved-1 #80

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 8 additions & 2 deletions src/components/Content.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,8 +30,14 @@ class Content extends Component {
getData = async(id) => {
try {
const { data } = await axios(`https://raw.githubusercontent.com/devsonket/devsonket.github.io/develop/data/${id}.json`);
let { data: contributor } = await axios(`https://api.github.com/repos/devsonket/devsonket.github.io/commits?path=data/${id}.json`);
contributor = contributorMap(contributor);
let contributorRaw = await axios(`https://api.github.com/repos/devsonket/devsonket.github.io/commits?path=data/${id}.json`);
console.log(contributorRaw); // kept this to check the behaviour as I can't recreate the scenario
let { data: contributor } = contributorRaw;
if(contributorRaw.status !== 200) {
contributor = null;
} else {
contributor = contributorMap(contributor);
}
this.setState({data, contributor});
this.setTitle();
} catch(e) {
Expand Down
4 changes: 2 additions & 2 deletions src/components/HeaderContent.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ export default class HeaderContent extends PureComponent {
<div className="intro">
<h1>{title}</h1>
<p>{description}</p>
<ul className="contributor no-print">
{contributor && <ul className="contributor no-print">
<p>কন্ট্রিবিউটর</p>
{Object.keys(contributor).map(oneContributor => (
<li key={oneContributor}>
Expand All @@ -24,7 +24,7 @@ export default class HeaderContent extends PureComponent {
</div>
</li>
))}
</ul>
</ul>}
<div className="print no-print">
<button className="btn btn-print" onClick={() => window.print()}>প্রিন্ট করুন</button>
</div>
Expand Down