Skip to content

Unneccessary 5s wait at pkg\devspace\cloud\cluster.go in function defaultClusterSpaceDomain #586

@FlorianKutz

Description

@FlorianKutz

What happened?
I called this function with useHostNetwork set to false. The function immediatly received the loadBalancer so the function could continue right away. But it doesn't. It waits 5 seconds until it continues. This is very unneccessary.

What did you expect to happen instead?
No time.Sleep(5 Seconds).

How can we reproduce the bug? (as minimally and precisely as possible)
Just run the cluster_test.

Local Environment:

  • Operating System: windows

Anything else we need to know?
Also I belive if the service is returned in the last loop, it fails despite that because of the "time.Since(now) >= waitTimeout"-condition. Why not:
if hostname == "" && ip == "" { return errors.New(...) }

/kind bug

Metadata

Metadata

Assignees

Labels

kind/enhancementEnhancement of an existing feature / improvement

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions