Add unset nature to set and set string flags#2061
Merged
FabianKramm merged 1 commit intodevspace-sh:masterfrom May 4, 2022
Merged
Conversation
✅ Deploy Preview for devspace-docs ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
FabianKramm
approved these changes
May 2, 2022
Collaborator
FabianKramm
left a comment
FabianKramm
left a comment
There was a problem hiding this comment.
@tukobadnyanoba thanks for the PR! LGTM!
tukobadnyanoba
force-pushed
the
add-unset-nature-to-set-and-set-string-flags
branch
from
d2f66a9 to
2ff4c9e
Compare
tukobadnyanoba
force-pushed
the
add-unset-nature-to-set-and-set-string-flags
branch
from
2ff4c9e to
e491505
Compare
FabianKramm
approved these changes
May 4, 2022
Collaborator
FabianKramm
left a comment
FabianKramm
left a comment
There was a problem hiding this comment.
@tukobadnyanoba thanks for the PR! LGTM!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What issue type does this pull request address? (keep at least one, remove the others)
/kind enhancement
Sets the keys to null when they are added to flags.
What does this pull request do? Which issues does it resolve? (use
resolves #<issue_number>if possible)resolves #
Please provide a short message that should be published in the DevSpace release notes
Fixed an issue where DevSpace ...
What else do we need to know?