removed fake k8s client#2067
Merged
FabianKramm merged 1 commit intodevspace-sh:masterfrom May 6, 2022
Merged
Conversation
✅ Deploy Preview for devspace-docs ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
tukobadnyanoba
force-pushed
the
skip-k8s-config
branch
from
ff50d3d to
5b0a6fb
Compare
tukobadnyanoba
force-pushed
the
skip-k8s-config
branch
from
5b0a6fb to
276d71e
Compare
FabianKramm
approved these changes
May 6, 2022
Collaborator
FabianKramm
left a comment
FabianKramm
left a comment
There was a problem hiding this comment.
@tukobadnyanoba thanks a lot for the PR! LGTM!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What issue type does this pull request address? (keep at least one, remove the others)
/kind bugfix
Earlier for non-existing kubeconfigs, we used to create fakeclientset, I have removed that logic now. If the kubeconfig is needed for build operation using kaniko and buildkit, there are already checks present to validate. If the docker build is fired, we don't need k8s cluster, so its now executed without any error.
What does this pull request do? Which issues does it resolve? (use
resolves #<issue_number>if possible)resolves #
Please provide a short message that should be published in the DevSpace release notes
Fixed an issue where DevSpace ...
What else do we need to know?