Skip to content

fix: use discard logger when init command renders helm charts#2095

Merged
FabianKramm merged 1 commit intodevspace-sh:masterfrom
lizardruss:fix_init_render
Jun 10, 2022
Merged

fix: use discard logger when init command renders helm charts#2095
FabianKramm merged 1 commit intodevspace-sh:masterfrom
lizardruss:fix_init_render

Conversation

@lizardruss
Copy link
Copy Markdown
Collaborator

What issue type does this pull request address? (keep at least one, remove the others)
/kind bugfix

What does this pull request do? Which issues does it resolve?
Fixes a fatal error that's thrown when prompting the user for which image they would like to develop with DevSpace:

? Please specify the name of the chart within your chart repository (e.g. payment-service) sealed-secrets
fatal cannot ask question 'Which image do you want to develop with DevSpace?' because log level is too low
github.com/loft-sh/devspace/pkg/util/log.(*StreamLogger).Question
        /Users/runner/work/devspace/devspace/pkg/util/log/stream_logger.go:525
github.com/loft-sh/devspace/cmd.(*InitCmd).initDevspace
        /Users/runner/work/devspace/devspace/cmd/init.go:354
github.com/loft-sh/devspace/cmd.(*InitCmd).Run
        /Users/runner/work/devspace/devspace/cmd/init.go:160
github.com/loft-sh/devspace/cmd.NewInitCmd.func1
        /Users/runner/work/devspace/devspace/cmd/init.go:92
github.com/spf13/cobra.(*Command).execute
        /Users/runner/work/devspace/devspace/vendor/github.com/spf13/cobra/command.go:856
github.com/spf13/cobra.(*Command).ExecuteC
        /Users/runner/work/devspace/devspace/vendor/github.com/spf13/cobra/command.go:974
github.com/spf13/cobra.(*Command).Execute
        /Users/runner/work/devspace/devspace/vendor/github.com/spf13/cobra/command.go:902
github.com/loft-sh/devspace/cmd.Execute
        /Users/runner/work/devspace/devspace/cmd/root.go:134
main.main
        /Users/runner/work/devspace/devspace/main.go:20
runtime.main
        /Users/runner/hostedtoolcache/go/1.17.10/x64/src/runtime/proc.go:255
runtime.goexit
        /Users/runner/hostedtoolcache/go/1.17.10/x64/src/runtime/asm_arm64.s:1133

Please provide a short message that should be published in the DevSpace release notes
Fixed an issue where DevSpace devspace init would error unexpectedly when prompting for input.

@netlify
Copy link
Copy Markdown

netlify Bot commented Jun 8, 2022

Deploy Preview for devspace-docs ready!

Name Link
🔨 Latest commit a5ec916
🔍 Latest deploy log https://app.netlify.com/sites/devspace-docs/deploys/62a0fb80bc32e800091b1c2d
😎 Deploy Preview https://deploy-preview-2095--devspace-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@FabianKramm FabianKramm merged commit 935f8e6 into devspace-sh:master Jun 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants