feat: add fish completion#2154
Merged
FabianKramm merged 1 commit intodevspace-sh:masterfrom Jul 5, 2022
nberlee:fish-completion
Merged
feat: add fish completion#2154FabianKramm merged 1 commit intodevspace-sh:masterfrom nberlee:fish-completion
FabianKramm merged 1 commit intodevspace-sh:masterfrom
nberlee:fish-completion
Conversation
Signed-off-by: Nico Berlee <nico.berlee@on2it.net>
FabianKramm
approved these changes
Jul 5, 2022
Collaborator
FabianKramm
left a comment
FabianKramm
left a comment
There was a problem hiding this comment.
@nberlee thanks for the PR! LGTM!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Nico Berlee nico.berlee@on2it.net
What issue type does this pull request address? (keep at least one, remove the others)
/kind feature
What does this pull request do? Which issues does it resolve? (use
resolves #<issue_number>if possible)Add fish completion support
Please provide a short message that should be published in the DevSpace release notes
Add completion generation support for fish shell
What else do we need to know?
not sure what happend to cli.md, the documenation generation did that... shall I remove it from the commit?